Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Include ExpandableBottomSheetController #14

Open
alestiago opened this issue Nov 1, 2021 · 5 comments
Open

Include ExpandableBottomSheetController #14

alestiago opened this issue Nov 1, 2021 · 5 comments
Labels
feature A new feature for the package in dev
Milestone

Comments

@alestiago
Copy link
Contributor

Description

Use ExpandableBottomSheetController instead of key to manage the state of the ExpandableBottomSheet.

@alestiago
Copy link
Contributor Author

alestiago commented Nov 1, 2021

@torbenkeller I can work on this issue. Let me know if you agree with this change, since this can include a breaking change to the current API.

@torbenkeller
Copy link
Owner

Sorry for the late reply. I think a ExpandableBottomSheetController would be a better interface so feel free to work on this :)

@alestiago
Copy link
Contributor Author

alestiago commented Nov 21, 2021

@torbenkeller , I started working on the implementation of the ExpandableBottomSheetController. Let me know your thoughts about #15 , which is currently under development.

@Kinomad
Copy link

Kinomad commented Nov 24, 2021

Hi, congratulations for you great job :)
Can be very nice and useful to have an ExpandableBottomSheetController, especially to get and control the offset of the ExpandableBottomSheet. Impatient to get this new feature, do you have an idea when it should be available?
Thanks for your work !

@alestiago
Copy link
Contributor Author

Hi @Kinomad thank you for the feedback, it means a lot! 💙

I'm not sure when the feature will be finished. I've already started working on it, you can check the PR #15 . Feel free to make a code review and leave some feedback about it, I would really appreciate it 😄

@torbenkeller torbenkeller added in dev feature A new feature for the package labels Dec 5, 2021
@torbenkeller torbenkeller added this to the v 2.0.0 milestone Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature for the package in dev
Projects
None yet
Development

No branches or pull requests

3 participants