Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some AVITI data to the fastq-test-suite #6

Open
colinbrislawn opened this issue Oct 31, 2024 · 2 comments
Open

add some AVITI data to the fastq-test-suite #6

colinbrislawn opened this issue Oct 31, 2024 · 2 comments

Comments

@colinbrislawn
Copy link
Contributor

This is the new Illumina competitor from Element Biosciences @Elembio

People are using it amplicons: qiime2 forums xref, benjjneb/dada2#1893, company website

The q-scores are higher than Illumina's but idk what that means yet

I looked for public test data and couldn't find any

@frederic-mahe
Copy link
Collaborator

frederic-mahe commented Oct 31, 2024

thanks @colinbrislawn

related issues: torognes/vsearch#522 and torognes/vsearch#564

As of now, vsearch can handle fastq quality values up to 41 by default and up to 93 with the proper option (--fastq_qmax 93). That's the end of the ASCII table when using an offset of 33 (93 + 33 = 126 = ~, the last printable ASCII symbol).

We could:

  • change nothing (fatal error when Q > 41),
  • accept Q values between 41 and 93 with a warning,
  • set 93 as the new default upper limit for Q values

@colinbrislawn
Copy link
Contributor Author

Well, there's no fastq spec. 'standards' https://xkcd.com/927/

For my own notes, Wikipedia has a surprisingly good section on the Phred offset debacle:
https://en.wikipedia.org/wiki/FASTQ_format#Encoding

I would love to have a good way to autodetect offset and help users fix mistakes, but I'm not sure that's possible.

Perhaps fastq 'correctness' should come upstream and we simply trust the scores as written.

set 93 as the new default upper limit for Q values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants