Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MySQL utf8 option in favor of utf8mb4 #314

Open
discomrade opened this issue Jul 11, 2021 · 0 comments
Open

Remove MySQL utf8 option in favor of utf8mb4 #314

discomrade opened this issue Jul 11, 2021 · 0 comments

Comments

@discomrade
Copy link
Collaborator

#193 Related?

Vichan has legacy code to manually extract the version number of MySQL to check if it's greater than or less than 5.5.3 (from 2010) and if it is less, make changes to the database on installation and to character encodings when inserting into the MySQL.
MariaDB versions can have version numbers that cannot be interpreted by this function, resulting in strange behavior.

My recommendation is:

  • transforming our database to use utf8mb4 instead of utf8
  • officially stop supporting MySQL < 5.5.3
  • remove all references to mysql_version()

One manifestation of this bug is failing to edit posts with emoji in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant