Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images which include built tpm2-tss #28

Open
johnandersen777 opened this issue Mar 10, 2020 · 1 comment
Open

Images which include built tpm2-tss #28

johnandersen777 opened this issue Mar 10, 2020 · 1 comment

Comments

@johnandersen777
Copy link
Member

The container we're publishing is a bit of a misnomer. Its tpm2software/tpm2-tss but the tss isn't in that container.

I'd argue the container images in this repo should really be tpm2-base. Since it's the base image required to compile the tss.

We should then have Dockerfiles in each other repo which provide built versions of those projects respectively named.

@williamcroberts
Copy link
Member

The container we're publishing is a bit of a misnomer. Its tpm2software/tpm2-tss but the tss isn't in that container.

No it was just a name... I never intended it to mean that.

I'd argue the container images in this repo should really be tpm2-base. Since it's the base image required to compile the tss.

I can see that argument...

We should then have Dockerfiles in each other repo which provide built versions of those projects respectively named.

Which build, latest release, master, etc? The containers are really intended just for the CI or near ready to go sandboxes for playing in.

Renaming gets fun, because things then all need to be updated in all the other projects that use these for the CI pipeline. As much as I like where your head is on this, I don't think renaming them really adds that much value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants