Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestsにLimitとOffsetパラメータを追加 #806

Merged
merged 6 commits into from
Dec 29, 2024

Conversation

reiroop
Copy link
Contributor

@reiroop reiroop commented Nov 8, 2024

requests_testは未対応

@reiroop reiroop self-assigned this Nov 8, 2024
@reiroop reiroop linked an issue Nov 8, 2024 that may be closed by this pull request
@reiroop reiroop marked this pull request as draft November 9, 2024 13:20
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 17.14286% with 29 lines in your changes missing coverage. Please review.

Project coverage is 25.31%. Comparing base (c3dbb3b) to head (3035835).
Report is 7 commits behind head on v2.

Files with missing lines Patch % Lines
router/request.go 12.50% 26 Missing and 2 partials ⚠️
router/transaction.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #806      +/-   ##
==========================================
+ Coverage   25.30%   25.31%   +0.01%     
==========================================
  Files         147      147              
  Lines       30769    30803      +34     
==========================================
+ Hits         7787     7799      +12     
- Misses      22095    22116      +21     
- Partials      887      888       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reiroop reiroop marked this pull request as ready for review December 28, 2024 14:55
@reiroop reiroop requested a review from H1rono December 28, 2024 14:55
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう
一回go mod tidyしてみて欲しいです(go.sumがなんか変わるかも)

@reiroop
Copy link
Contributor Author

reiroop commented Dec 29, 2024

良さそう 一回go mod tidyしてみて欲しいです(go.sumがなんか変わるかも)

やった

@reiroop reiroop merged commit 27d5da6 into v2 Dec 29, 2024
6 of 7 checks passed
@reiroop reiroop deleted the feat/add_limit_offset_to_requests_parameters branch December 29, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requestsにlimit, offsetをつける
2 participants