samber/lo

[H1rono]

#771 でインストールした
他にも使えるところがあるかも？

[H1rono]

究極、appendを撲滅できるよな

[H1rono]

Jomon/router/admin.go

Lines 20 to 23 in ef91d11

	res := []*uuid.UUID{}
	for _, admin := range admins {
	res = append(res, &admin.ID)
	}

Jomon/model/tag_impl.go

Lines 19 to 22 in ef91d11

	modeltags := []*Tag{}
	for _, t := range tags {
	modeltags = append(modeltags, ConvertEntTagToModelTag(t))
	}

Jomon/model/user_impl.go

Lines 54 to 57 in ef91d11

	var modelusers []*User
	for _, u := range users {
	modelusers = append(modelusers, convertEntUserToModelUser(u))
	}

Jomon/model/group_impl.go

Lines 19 to 22 in ef91d11

	modelgroups := []*Group{}
	for _, g := range groups {
	modelgroups = append(modelgroups, ConvertEntGroupToModelGroup(g))
	}

Jomon/model/group_impl.go

Lines 84 to 87 in ef91d11

	owners := []*Owner{}
	for _, groupowner := range groupowners {
	owners = append(owners, &Owner{ID: groupowner.ID})
	}

Jomon/model/group_impl.go

Lines 101 to 104 in ef91d11

	resowners := []*Owner{}
	for _, owner := range ownerIDs {
	resowners = append(resowners, &Owner{ID: owner})
	}

Jomon/model/group_impl.go

Lines 130 to 133 in ef91d11

	modelmembers := []*Member{}
	for _, member := range members {
	modelmembers = append(modelmembers, &Member{member.ID})
	}

Jomon/model/group_impl.go

Lines 148 to 151 in ef91d11

	resMembers := []*Member{}
	for _, member := range userIDs {
	resMembers = append(resMembers, &Member{member})
	}

[H1rono]

Jomon/router/transaction.go

Lines 139 to 147 in ef91d11

	tags := []*TagOverview{}
	for _, tag := range tx.Tags {
	tags = append(tags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/transaction.go

Lines 195 to 203 in ef91d11

	tags := []*TagOverview{}
	for _, tag := range created.Tags {
	tags = append(tags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/transaction.go

Lines 245 to 253 in ef91d11

	tags := []*TagOverview{}
	for _, tag := range tx.Tags {
	tags = append(tags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/transaction.go

Lines 299 to 307 in ef91d11

	tags := []*TagOverview{}
	for _, tag := range updated.Tags {
	tags = append(tags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

↓バグに見える

Jomon/router/request.go

Lines 188 to 195 in ef91d11

	for _, tag := range request.Tags {
	tags = append(tags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/request.go

Lines 197 to 206 in ef91d11

	restargets := []*TargetOverview{}
	for _, target := range request.Targets {
	restargets = append(restargets, &TargetOverview{
	ID: target.ID,
	Target: target.Target,
	Amount: target.Amount,
	PaidAt: target.PaidAt,
	CreatedAt: target.CreatedAt,
	})
	}

Jomon/router/request.go

Lines 259 to 265 in ef91d11

	targets := []*model.RequestTarget{}
	for _, target := range req.Targets {
	targets = append(targets, &model.RequestTarget{
	Target: target.Target,
	Amount: target.Amount,
	})
	}

Jomon/router/request.go

Lines 298 to 307 in ef91d11

	var reqtargets []*TargetOverview
	for _, target := range request.Targets {
	reqtargets = append(reqtargets, &TargetOverview{
	ID: target.ID,
	Target: target.Target,
	Amount: target.Amount,
	PaidAt: target.PaidAt,
	CreatedAt: target.CreatedAt,
	})
	}

Jomon/router/request.go

Lines 308 to 316 in ef91d11

	var restags []*TagOverview
	for _, tag := range request.Tags {
	restags = append(restags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/request.go

Lines 317 to 324 in ef91d11

	var statuses []*StatusResponseOverview
	for _, status := range request.Statuses {
	statuses = append(statuses, &StatusResponseOverview{
	Status: status.Status,
	CreatedAt: status.CreatedAt,
	CreatedBy: status.CreatedBy,
	})
	}

Jomon/router/request.go

Lines 371 to 381 in ef91d11

	comments := []*CommentDetail{}
	for _, modelcomment := range modelcomments {
	comment := &CommentDetail{
	ID: modelcomment.ID,
	User: modelcomment.User,
	Comment: modelcomment.Comment,
	CreatedAt: modelcomment.CreatedAt,
	UpdatedAt: modelcomment.UpdatedAt,
	}
	comments = append(comments, comment)
	}

Jomon/router/request.go

Lines 393 to 402 in ef91d11

	reqtargets := []*TargetOverview{}
	for _, target := range request.Targets {
	reqtargets = append(reqtargets, &TargetOverview{
	ID: target.ID,
	Target: target.Target,
	Amount: target.Amount,
	PaidAt: target.PaidAt,
	CreatedAt: target.CreatedAt,
	})
	}

Jomon/router/request.go

Lines 403 to 411 in ef91d11

	restags := []*TagOverview{}
	for _, tag := range request.Tags {
	restags = append(restags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/request.go

Lines 412 to 419 in ef91d11

	var resstatuses []*StatusResponseOverview
	for _, status := range request.Statuses {
	resstatuses = append(resstatuses, &StatusResponseOverview{
	CreatedBy: status.CreatedBy,
	Status: status.Status,
	CreatedAt: status.CreatedAt,
	})
	}

Jomon/router/request.go

Lines 468 to 474 in ef91d11

	targets := []*model.RequestTarget{}
	for _, target := range req.Targets {
	targets = append(targets, &model.RequestTarget{
	Target: target.Target,
	Amount: target.Amount,
	})
	}

Jomon/router/request.go

Lines 501 to 511 in ef91d11

	var comments []*CommentDetail
	for _, modelcomment := range modelcomments {
	comment := &CommentDetail{
	ID: modelcomment.ID,
	User: modelcomment.User,
	Comment: modelcomment.Comment,
	CreatedAt: modelcomment.CreatedAt,
	UpdatedAt: modelcomment.UpdatedAt,
	}
	comments = append(comments, comment)
	}

Jomon/router/request.go

Lines 524 to 532 in ef91d11

	var restags []*TagOverview
	for _, tag := range request.Tags {
	restags = append(restags, &TagOverview{
	ID: tag.ID,
	Name: tag.Name,
	CreatedAt: tag.CreatedAt,
	UpdatedAt: tag.UpdatedAt,
	})
	}

Jomon/router/request.go

Lines 533 to 542 in ef91d11

	var restargets []*TargetOverview
	for _, target := range request.Targets {
	restargets = append(restargets, &TargetOverview{
	ID: target.ID,
	Target: target.Target,
	Amount: target.Amount,
	PaidAt: target.PaidAt,
	CreatedAt: target.CreatedAt,
	})
	}

Jomon/router/request.go

Lines 543 to 550 in ef91d11

	var resstatuses []*StatusResponseOverview
	for _, status := range request.Statuses {
	resstatuses = append(resstatuses, &StatusResponseOverview{
	CreatedBy: status.CreatedBy,
	Status: status.Status,
	CreatedAt: status.CreatedAt,
	})
	}

[H1rono]

多すぎ...

[H1rono]

Jomon/router/request.go

Lines 707 to 717 in 1db6bd3

	var paid bool
	for _, target := range targets {
	if target.PaidAt != nil {
	paid = true
	break
	}
	}
	if paid {
	h.Logger.Info("someone already paid")
	return echo.NewHTTPError(http.StatusBadRequest, errors.New("someone already paid"))
	}

ここlo.Reduce使える

[Hueter57]

resが一度resesを経由しているのは何か意味あるんですかね

Jomon/router/transaction_test.go

Lines 663 to 693 in 6a1f7eb

	reses := []*Transaction{}
	for _, tx := range txs {
	tag := []*TagOverview{}
	for _, modelTag := range tx.Tags {
	tag = append(tag, &TagOverview{
	ID: modelTag.ID,
	Name: modelTag.Name,
	CreatedAt: modelTag.CreatedAt,
	UpdatedAt: modelTag.UpdatedAt,
	})
	}
	group := &GroupOverview{
	ID: tx.Group.ID,
	Name: tx.Group.Name,
	Description: tx.Group.Description,
	Budget: tx.Group.Budget,
	CreatedAt: tx.Group.CreatedAt,
	UpdatedAt: tx.Group.UpdatedAt,
	}
	resOverview = Transaction{
	ID: tx.ID,
	Amount: tx.Amount,
	Target: tx.Target,
	Tags: tag,
	Group: group,
	CreatedAt: tx.CreatedAt,
	UpdatedAt: tx.UpdatedAt,
	}
	reses = append(reses, &resOverview)
	}
	res := reses

ここだとresOverviewを経由してます

Jomon/router/transaction_test.go

Line 555 in 6a1f7eb

resOverview := []*Transaction{}

やってることが変わらないので一旦経由しているもの消して書いてます

[H1rono]

できますね、やっちゃってください
途中でbreakなりreturnなりが入っていない限りはlo.Mapに置き換えてOK
可能であればPRでは置き換えなかったfor文もできれば列挙して欲しいです

[H1rono]

closed by #789