JWT発行API #462
Closed
JWT発行API #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UIがないのでknoQの開発環境開いてOAuth2認証をした上で await (await fetch('/api/token', {
method: 'POST',
headers: {
'Content-Type': 'application/json'
}
})).json()をしてtokenを発行します await (await fetch('/api/events', {
headers: {
'Content-Type': 'application/json',
'Authorization': 'Bearer {ここにトークン}'
}
})).json()をするとOAuth2認証なしでイベントが取れると思います |
ras0q
commented
Sep 24, 2023
Comment on lines
+97
to
+100
| ErrorHandler: func(c echo.Context, err error) error { | ||
| return nil | ||
| }, | ||
| ContinueOnIgnoredError: true, |
There was a problem hiding this comment.
これがないとJWTないとき弾かれるんだけどこれを追加していいのか自信がない
There was a problem hiding this comment.
単純にここの順番を入れ替えてしまうという手段がある（隠された実装に依存するけどたぶん配列回してるだけ）
There was a problem hiding this comment.
先に部員認証しちゃうとIDが入ってなくてトークン使えなさそう
hijiki51
requested changes
Sep 24, 2023
| @@ -80,6 +82,30 @@ func ServerVersionMiddleware(version string) echo.MiddlewareFunc { | |||
| } | |||
| } | |||
|
|
|||
| func (h *Handlers) JWTMiddleware() echo.MiddlewareFunc { | |||
| return echojwt.WithConfig( | |||
| echojwt.Config{ | |||
There was a problem hiding this comment.
Signing Methodは明示的に書いたほうがいい（デフォルト値だとわからないので）
Comment on lines
+97
to
+100
| ErrorHandler: func(c echo.Context, err error) error { | ||
| return nil | ||
| }, | ||
| ContinueOnIgnoredError: true, |
There was a problem hiding this comment.
単純にここの順番を入れ替えてしまうという手段がある（隠された実装に依存するけどたぶん配列回してるだけ）
|
別の手段で最低でも30日くらいは使えるトークンにする |
kwsk(このPRの実装だとうまく行かない理由教えてほしいです:pray:) |
|
JWTで30日は長すぎるみたいな指摘が入ったからですね |
|
多分これはマージされないのでクローズ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #422
knoQをブラウザを介さずに(BOT,他appなどから)アクセスしたい需要があったのでトークンを発行するAPIを書きました
そもそもJWTじゃないほうがいいとかあれば教えていただけるとありがたいです