From 26094193e8301f6bb15ca94c2be4bdeb386d2b4b Mon Sep 17 00:00:00 2001 From: Martin Hutchinson Date: Mon, 21 Oct 2024 14:10:59 +0000 Subject: [PATCH] Switch back to using cosignature This will reinstate timestamps in the witness signatures. This was dropped in #233 as a temporary measure to facilitate a transition between timestamp endianness. Any sigs that aren't verified are dropped, and thus the currently deployed distributors will drop the cosignature signatures. If we want to support keeping both witness signatures around, we'll have to do some more engineering to have multiple verifiers per witness. We would also need to look at the merging code to ensure we only merge similar signatures. It seems easier to just drop the non-timestamped sigs on entry. --- config/config.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/config/config.go b/config/config.go index 50709a6..ec9b99d 100644 --- a/config/config.go +++ b/config/config.go @@ -81,8 +81,7 @@ func ParseWitnessesConfig(y []byte) (map[string]note.Verifier, error) { } ws := make(map[string]note.Verifier) for _, w := range witCfg.Witnesses { - // TODO(mhutchinson): Upgrade this to f_note.NewVerifierForCosignatureV1 - wSigV, err := note.NewVerifier(w) + wSigV, err := f_note.NewVerifierForCosignatureV1(w) if err != nil { return nil, fmt.Errorf("invalid witness public key: %v", err) }