Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lyrics aren't fetched on the first try #138

Open
vlnka opened this issue Oct 2, 2024 · 6 comments
Open

Lyrics aren't fetched on the first try #138

vlnka opened this issue Oct 2, 2024 · 6 comments

Comments

@vlnka
Copy link

vlnka commented Oct 2, 2024

I have a library of about 50k tracks I ran LRCGET on. It found lyrics for most of them which is great.

But when I ran it in the same folder again, lyrics for more tracks were found. I did that several times back-to-back and it always found lyrics for a few more tracks.

Any idea what causes this? Why can't lyrics for all tracks be fetched successfully in one run?

@tranxuanthang
Copy link
Owner

It is expected, you can see my answer in this issue for more explanation: #132 (comment)

@vlnka
Copy link
Author

vlnka commented Oct 2, 2024

I somewhat refuse to believe lyrics for ~30% (about 4k) of my previous undetected songs popped up within 2 hours of the initial fetch

@fineless71
Copy link

fineless71 commented Oct 2, 2024

It always redownloads lyrics if a track has only plain and not synced lyrics, maybe that is what is happening? I think it would be more clear if it said something like "Plain lyrics already downloaded" for those tracks

It also seems to always redownload even synced lyrics if you download for a specific album

@vlnka
Copy link
Author

vlnka commented Oct 2, 2024

oh does it? weird

not sure how related it is but this also keep happenings when i'm running a scan on a library where some songs already have their lyrics - multiple lines for the same track
image

Repository owner deleted a comment from thangtranxuan-vti Oct 3, 2024
@tranxuanthang
Copy link
Owner

@vlnka

not sure how related it is but this also keep happenings when i'm running a scan on a library where some songs already have their lyrics - multiple lines for the same track

It looks like it's a new bug unrelated to your original post, I'll check this out later today.

I somewhat refuse to believe lyrics for ~30% (about 4k) of my previous undetected songs popped up within 2 hours of the initial fetch

It is actually true, you might get a few more lyrics if you rerun after a couple of days (2 hours is sometimes too short).

It always redownloads lyrics if a track has only plain and not synced lyrics, maybe that is what is happening? I think it would be more clear if it said something like "Plain lyrics already downloaded" for those tracks

It also seems to always redownload even synced lyrics if you download for a specific album

@fineless71 I think it is not related to OP's issue. You can read more in #30

@Zedniac
Copy link

Zedniac commented Oct 5, 2024

Regarding the issue where multiple lines show up for the same track, I've noticed that as well. Often happens if I scroll in the list while it's scanning. Happy to provide more info or try to recreate the issue if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants