Update elm integration for 2020 #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versioning scheme has changed with the release of elm 0.19.0. Instead of npm tags of the form: elmMAJOR.MINOR.PATCH elm npm packages use tags of the form: latest-MAJOR.MINOR.PATCH. This commit updates travis-builds logic to pick the correct prefix. It will default to using the "latest-" prefix unless the config it towards the "elm" prefix.
avh4
previously approved these changes
Mar 14, 2020
rtfeldman
previously approved these changes
Mar 20, 2020
|
Updated the pull request to use latest node version |
|
I think the CI failures are unrelated to this change as master has also gone red and the error log talks about files this PR does not touch. |
BanzaiMan
reviewed
Mar 30, 2020
BanzaiMan
reviewed
Mar 30, 2020
|
Have applied suggestions. Thanks @BanzaiMan |
|
Great! Planning a deployment early next week. |
|
Thanks @BanzaiMan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes:
A new patch release of elm has been released (elm
0.19.1). This pull request uses it by default whenlanguage: elm.The way elm versions are tagged on npm has also changed (see 1, 2 and 3) to use tags of the form
latest-0.19.1instead ofelm0.19.1. This tagging has been applied retrospectively to versions0.18.0onwards (all the versions that travis supports). Notably, the0.19.1release has not been tagged aselm0.19.1which means the.travis.ymlconfig:errors when run in travis. This PR updates travis-build to use tags of the form
latest-0.19.1by default.This PR builds #1718, #1613, #1605 and #934
cc: @avh4, @lukewestby, @stoeffel and @rtfeldman