Add Elm language support #934

rtfeldman · 2017-01-20T05:09:05Z

This adds Elm support to Travis.

Happy to do as much revision to this as necessary! Also I'd be happy to push branches of some of my Elm projects to have them use language: elm in their .travis.yml files for the staging tests.

BanzaiMan · 2017-01-20T16:41:24Z

Hi, there! Thank you for your interest in adding Elm to Travis CI.

If you have not done so, please read https://docs.travis-ci.com/user/languages/community-supported-languages/ for some additional details. (Some of the details are a bit out of date; in particular, the bits on travis-core in https://docs.travis-ci.com/user/languages/community-supported-languages/#Code since that library is no longer relevant to community-supported languages. See travis-ci/docs-travis-ci-com#819.)

rtfeldman · 2017-01-21T21:27:03Z

Yep! That page was my starting point. 😁

rtfeldman · 2017-02-03T16:50:27Z

@BanzaiMan Just wanted to check - is there anything you need from me on this? Or just waiting on review?

BanzaiMan · 2017-02-03T16:57:02Z

Please gather a few other volunteers to provide support. Thanks.

lukewestby · 2017-02-06T06:05:16Z

@BanzaiMan @rtfeldman I can help

avh4 · 2017-02-06T07:25:13Z

I can help as well. I'll also add this to the elm-community projects list so we can document who's actively part of the support team.

rtfeldman · 2017-02-06T07:58:45Z

@BanzaiMan done! 😄

stoeffel · 2017-02-06T08:51:51Z

@rtfeldman I can help!

rtfeldman · 2017-02-14T00:39:36Z

@BanzaiMan friendly ping! 😃

rtfeldman · 2017-02-19T04:53:22Z

@BanzaiMan anything we still need to do to unblock review?

rtfeldman · 2017-02-26T23:29:32Z

@BanzaiMan friendly ping! 🙂

lib/travis/build/script/elm.rb

+          end
+
+          def install_elm
+            sh.cmd 'npm install -g [email protected]', retry: true


BanzaiMan · 2017-03-01T19:36:07Z

Am I correct to understand that Elm requires a Node.js/JavaScript image?

rtfeldman · 2017-03-01T21:53:38Z

Am I correct to understand that Elm requires a Node.js/JavaScript image?

@BanzaiMan Elm doesn't, but elm-test does, and it's reasonable to assume people will want that for CI. 😄

BanzaiMan · 2017-03-01T22:19:52Z

Are there other requirements, such as required Node.js version and NPM version?

rtfeldman · 2017-03-02T00:03:25Z

@BanzaiMan ideally Node 6 and npm 3 (any minor versions within those major versions should be fine).

lib/travis/build/script/elm.rb

+module Travis
+  module Build
+    class Script
+      class Elm < Script


.nvmrc

@@ -0,0 +1 @@
+6.10.0


lib/travis/build/script/elm.rb

+module Travis
+  module Build
+    class Script
+      class Elm < Travis::Build::Script::NodeJs


lib/travis/build/script/elm.rb

+          end
+
+          def install_elm
+            npm_install "-g elm@elm-#{elm_version}"


BanzaiMan

With the suggested changes, the build proceeds to user-defined phases.

lib/travis/build/script/elm.rb

+          end
+
+          def install_elm
+            npm_install "-g elm@elm-#{elm_version}"


lib/travis/build/script/elm.rb

+        DEFAULTS = {
+          elm: '0.19.0',
+          elm_test: '0.19.0',
+          elm_format: '0.19.0'


BanzaiMan

More suggestions; for improving log readability.

lib/travis/build/script/elm.rb

Add Elm language support

BanzaiMan · 2018-11-20T13:19:11Z

Tested: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/jobs/734314

BanzaiMan · 2018-11-20T13:20:52Z

Thank you, @rtfeldman! It looks very good.

We'll be moving to https://travis-ci.community/ for support issues. We'll tweak the display text accordingly before releasing.

The current plan is to announce Elm support on ~~December 4~~ November 27, 2018.

lib/travis/build/script/elm.rb

Add Elm language support

BanzaiMan · 2018-11-20T17:01:40Z

Needs docs PR.

rtfeldman · 2018-11-20T18:14:51Z

Needs docs PR.

Is this something I should do? 😄

BanzaiMan · 2018-11-20T18:19:00Z

@rtfeldman I think I can do this, given the short time frame we've got. I should've pointed this out much earlier.

BanzaiMan · 2018-11-20T19:12:40Z

@rtfeldman What is the intended interactions among elm, elm_test, and elm_format? Currently, these can be independently defined, which I think is OK, but if one changes only elm, then elm_test and elm_format fall out of sync with it. That is to say:

language: elm
elm: 0.20.0 # a future release

will use Elm 0.20.0, but elm_test and elm_format remains at elm0.19.0, which is the default.

I am unfamiliar with the Elm ecosystem, but I imagine that this is not an ideal situation. From the user's perspective, its seems to me that elm value should propagate to the other two tools that depend on it (unless, of course, elm_test or elm_format is overridden.)

BanzaiMan · 2018-11-20T19:14:46Z

On a related note: how useful is the matrix expansion on elm_test and elm_format? It makes sense for the repository to test on multiple Elm versions, but I would like to not have to expand on elm_test and elm_format, to prevent enormous build matrices.

BanzaiMan · 2018-11-26T16:23:07Z

@rtfeldman

We plan to announce this tomorrow (2018-11-27) with the changes I suggested earlier. Namely:

The elm version propagates to elm_test and elm_format tag, unless these are explicitly overridden in the configuration.
There will be no matrix expansion on elm_test and elm_format.

rtfeldman · 2018-11-26T16:28:41Z

@BanzaiMan that all sounds good!

Do you need me to make those changes?

BanzaiMan · 2018-11-26T17:08:20Z

@rtfeldman I can work on the changes I've suggested.

BanzaiMan · 2018-11-26T17:19:38Z

See 9fbe7e4, including specs, which show that:

The elm value drives elm_test and elm_format versions.
The elm value could be with or without the elm prefix (e.g., 0.19.0 or elm0.19.0) and TRAVIS_ELM_VERSION will retain it if the default is used, or the user supplies it; but TRAVIS_ELM_TEST_VERSION and TRAVIS_ELM_FORMAT_VERSION will always be prefixed with elm.

rtfeldman · 2018-11-27T03:11:32Z

Looks good, thanks for all your help @BanzaiMan! Super excited to see this land! 😃

Richard Feldman added 3 commits January 19, 2017 21:02

Add script/elm.rb

8d864ed

Add elm to build processes.

bf9d28d

Add elm_spec.rb

c8456af

BanzaiMan self-assigned this Jan 20, 2017

Switch to using elm-use so we get elm-format as well.

889e7aa

avh4 mentioned this pull request Feb 6, 2017

Create elm-community/travis-ci elm-community/guidelines#63

Open

Validate elm-format before running tests.

e55e6b5

BanzaiMan reviewed Mar 1, 2017

View reviewed changes

Specify elm-use version bounds

e9d6f6d

BanzaiMan reviewed Mar 2, 2017

View reviewed changes

lib/travis/build/script/elm.rb Outdated

module Travis

module Build

class Script

class Elm < Script

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Richard Feldman added 2 commits March 2, 2017 11:27

Use NodeJs base class

59f0e85

Add .nvmrc to set default Node version

bbd0617

BanzaiMan reviewed Mar 2, 2017

View reviewed changes

Fully qualify NodeJs

dcb800b

BanzaiMan reviewed Mar 2, 2017

View reviewed changes

lib/travis/build/script/elm.rb Outdated

module Travis

module Build

class Script

class Elm < Travis::Build::Script::NodeJs

This comment was marked as spam.

Sign in to view

BanzaiMan reviewed Nov 19, 2018

View reviewed changes

BanzaiMan reviewed Nov 20, 2018

View reviewed changes

lib/travis/build/script/elm.rb Show resolved Hide resolved

lib/travis/build/script/elm.rb Show resolved Hide resolved

lib/travis/build/script/elm.rb Show resolved Hide resolved

Richard Feldman added 5 commits November 20, 2018 04:33

Merge branch 'master' into add-elm

4f47671

vers2int -> travis_vers2int

2944552

Use npm_install_global over npm_install

f53ea8a

Add a blank line after announce

17d4a12

Add some colored echo statements

e386ff2

BanzaiMan added a commit that referenced this pull request Nov 20, 2018

Merge pull request #934 from rtfeldman/add-elm

24db35b

Add Elm language support

BanzaiMan reviewed Nov 20, 2018

View reviewed changes

lib/travis/build/script/elm.rb Outdated Show resolved Hide resolved

BanzaiMan reviewed Nov 20, 2018

View reviewed changes

lib/travis/build/script/elm.rb Outdated Show resolved Hide resolved

Move echoes inside sh.fold

96e46d2

BanzaiMan added a commit that referenced this pull request Nov 20, 2018

Merge pull request #934 from rtfeldman/add-elm

6d96955

Add Elm language support

This was referenced Nov 26, 2018

Add Elm documentation travis-ci/docs-travis-ci-com#2147

Merged

Add Elm support travis-ci/travis-yml#87

Merged

BanzaiMan merged commit 7070ea2 into travis-ci:master Nov 27, 2018

rtfeldman deleted the add-elm branch November 27, 2018 14:47

harrysarson mentioned this pull request Mar 14, 2020

Update elm integration for 2020 #1876

Merged

		@@ -0,0 +1 @@
		6.10.0

Add Elm language support #934

Add Elm language support #934

Conversation

rtfeldman commented Jan 20, 2017

BanzaiMan commented Jan 20, 2017

rtfeldman commented Jan 21, 2017

rtfeldman commented Feb 3, 2017

BanzaiMan commented Feb 3, 2017

lukewestby commented Feb 6, 2017

avh4 commented Feb 6, 2017

rtfeldman commented Feb 6, 2017

stoeffel commented Feb 6, 2017

rtfeldman commented Feb 14, 2017

rtfeldman commented Feb 19, 2017

rtfeldman commented Feb 26, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

BanzaiMan commented Mar 1, 2017

rtfeldman commented Mar 1, 2017

BanzaiMan commented Mar 1, 2017

rtfeldman commented Mar 2, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

BanzaiMan left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

BanzaiMan left a comment • edited Loading

Choose a reason for hiding this comment

BanzaiMan commented Nov 20, 2018

BanzaiMan commented Nov 20, 2018 • edited Loading

BanzaiMan commented Nov 20, 2018

rtfeldman commented Nov 20, 2018

BanzaiMan commented Nov 20, 2018

BanzaiMan commented Nov 20, 2018

BanzaiMan commented Nov 20, 2018

BanzaiMan commented Nov 26, 2018

rtfeldman commented Nov 26, 2018

BanzaiMan commented Nov 26, 2018

BanzaiMan commented Nov 26, 2018 • edited Loading

rtfeldman commented Nov 27, 2018

BanzaiMan left a comment •

edited

Loading

BanzaiMan commented Nov 20, 2018 •

edited

Loading

BanzaiMan commented Nov 26, 2018 •

edited

Loading