Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: React 19 support #1072

Open
eps1lon opened this issue May 30, 2024 · 4 comments
Open

[Feature]: React 19 support #1072

eps1lon opened this issue May 30, 2024 · 4 comments
Labels
Type: Refactor Restructuring or improving existing code

Comments

@eps1lon
Copy link

eps1lon commented May 30, 2024

What problem does this feature solve?

React 19 is already past its Alpha phase. During Alpha, libraries are encourage to start working on React 19 compatibility. This helps us flush out potential bugs before app developers start adopting React 19.

What does the proposed API look like?

At a glance, recharts and @headlessui/react are the libraries that are incompatible that stand out.

[email protected] should fix most of the compat issues (already tracked in #1054).

@headlessui/react had this compat issue: tailwindlabs/headlessui#3167. tailwindlabs/headlessui#3167 is already fixed on main. However, @tremor/react still uses 1.x so you'd need to bump @headlessui/react to 2.x first to have a chance of getting the fix for @headlessui/react.

@severinlandolt severinlandolt added the Type: Refactor Restructuring or improving existing code label Jun 1, 2024
@LUPLUV
Copy link

LUPLUV commented Jun 20, 2024

Will this be implemented soon? We would love to upgrade to react 19 while using tremor components :)

@michaelhays
Copy link

Upgrading package.json to [email protected] should fix this: recharts/recharts#4558

@rminami
Copy link

rminami commented Oct 24, 2024

Currently getting this from @headlessui/react when trying to use Tremor with React v19.

./node_modules/@tremor/react/node_modules/@headlessui/react/dist/utils/stable-collection.js
Attempted import error: '__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED' is not exported from 'react' (imported as 'r').

Import trace for requested module:
./node_modules/@tremor/react/node_modules/@headlessui/react/dist/utils/stable-collection.js
./node_modules/@tremor/react/node_modules/@headlessui/react/dist/components/tabs/tabs.js
__barrel_optimize__?names=Tab!=!./node_modules/@tremor/react/node_modules/@headlessui/react/dist/headlessui.esm.js
./node_modules/@tremor/react/dist/components/input-elements/Tabs/TabGroup.js
__barrel_optimize__?names=Tab,TabGroup,TabList!=!./node_modules/@tremor/react/dist/index.js

@AaronMBMorse
Copy link

@rminami you can force the @headlessui/react to version 2.20 using resolutions in your package.json file. This isn't a great solution for a production application but might work as a holdover until it's updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Restructuring or improving existing code
Projects
None yet
Development

No branches or pull requests

6 participants