forked from Automattic/vip-go-ci
-
Notifications
You must be signed in to change notification settings - Fork 0
/
auto-approval.php
682 lines (591 loc) · 13.6 KB
/
auto-approval.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
<?php
/**
* Pull-Request is not approved,
* remove label if needed, leave messages
* on files that are approved, dismiss
* any previously approving PRs.
*
* Note that the testing of this function is
* covered by tests of vipgoci_auto_approval().
*
* @codeCoverageIgnore
*/
function vipgoci_auto_approval_non_approval(
$options,
&$results,
$pr_item,
$pr_label,
&$auto_approved_files_arr,
$files_seen,
$pr_files_changed
) {
vipgoci_runtime_measure( VIPGOCI_RUNTIME_START, 'vipgoci_auto_approval_non_approval' );
vipgoci_counter_report(
VIPGOCI_COUNTERS_DO,
'github_pr_non_approval',
1
);
vipgoci_log(
'Will not auto-approve Pull-Request #' .
(int) $pr_item->number . ' ' .
'as it contains ' .
'files which are not ' .
'automatically approvable' .
' -- PR URL: https://github.com/' .
rawurlencode( $options['repo-owner'] ) .
'/' .
rawurlencode( $options['repo-name'] ) .
'/pull/' .
(int) $pr_item->number . ' ',
array(
'repo_owner' =>
$options['repo-owner'],
'repo_name' =>
$options['repo-name'],
'pr_number' =>
$pr_item->number,
'autoapprove-filetypes' =>
$options['autoapprove-filetypes'],
'auto_approved_files_arr' =>
$auto_approved_files_arr,
'files_seen' => $files_seen,
'pr_files_changed' => $pr_files_changed,
),
0,
true // Send to IRC
);
if ( false === $pr_label ) {
vipgoci_log(
'Will not attempt to remove label ' .
'from issue as it does not ' .
'exist',
array(
'repo_owner' => $options['repo-owner'],
'repo_name' => $options['repo-name'],
'pr_number' => $pr_item->number,
'label_name' => $options['autoapprove-label'],
)
);
}
else {
/*
* Remove auto-approve label
*/
vipgoci_github_label_remove_from_pr(
$options['repo-owner'],
$options['repo-name'],
$options['token'],
(int) $pr_item->number,
$pr_label->name,
$options['dry-run']
);
}
/*
* Loop through approved PHP and JS files,
* adding comment for each about it
* being approved in the hashes-to-hashes API.
*/
foreach(
$auto_approved_files_arr as
$approved_file =>
$approved_file_system
) {
/*
* Make sure that the file was
* really altered in the Pull-Request;
* this is to avoid any errors when
* submitting inline comments.
*/
if ( in_array(
$approved_file,
$pr_files_changed,
true
) === false ) {
vipgoci_log(
'Not adding auto-approved in hashes-api ' .
'database to results for file, as it ' .
'was not altered by the Pull-Request',
array(
'pr_number' => $pr_item->number,
'file_name' => $approved_file,
'pr_files_changed' => $pr_files_changed,
)
);
continue;
}
if (
$approved_file_system !==
'autoapprove-hashes-to-hashes'
) {
/*
* If not autoapproved by hashes-to-hashes,
* do not comment on it. Only PHP and JS files
* are auto-approved by hashes-to-hashes.
*/
continue;
}
$results[
'issues'
][
(int) $pr_item->number
]
[] = array(
'type' => VIPGOCI_STATS_HASHES_API,
'file_name' => $approved_file,
'file_line' => 1,
'issue' => array(
'message'=> VIPGOCI_FILE_IS_APPROVED_MSG,
'source'
=> 'WordPressVIPMinimum.' .
'Info.ApprovedHashesToHashesAPI',
'severity' => 1,
'fixable' => false,
'type' => 'INFO',
'line' => 1,
'column' => 1,
'level' =>'INFO'
)
);
$results[
'stats'
][
VIPGOCI_STATS_HASHES_API
][
(int) $pr_item->number
][
'info'
]++;
}
/*
* Remove any 'file is approved in ...' comments,
* but only for files that are no longer approved.
*/
vipgoci_log(
'Removing any comments indicating a file is approved ' .
'for files that are not approved anymore',
array(
'pr_number' => $pr_item->number,
)
);
$pr_comments = vipgoci_github_pr_reviews_comments_get_by_pr(
$options,
$pr_item->number,
array(
'login' => 'myself',
)
);
foreach( $pr_comments as $pr_comment_item ) {
/*
* Skip approved files.
*/
if ( isset(
$auto_approved_files_arr[
$pr_comment_item->path
]
) ) {
continue;
}
/*
* If we find the 'approved in hashes-to-hashes ...'
* message, we can safely remove the comment.
*/
if ( false !== strpos(
$pr_comment_item->body,
VIPGOCI_FILE_IS_APPROVED_MSG
) ) {
vipgoci_github_pr_reviews_comments_delete(
$options,
$pr_comment_item->id
);
}
}
/*
* Get any approving reviews for the Pull-Request
* submitted by us. Then dismiss them.
*/
vipgoci_log(
'Dismissing any approving reviews for ' .
'the Pull-Request, as it is not ' .
'approved anymore',
array(
'pr_number' => $pr_item->number,
)
);
$pr_item_reviews = vipgoci_github_pr_reviews_get(
$options['repo-owner'],
$options['repo-name'],
(int) $pr_item->number,
$options['token'],
array(
'login' => 'myself',
'state' => array( 'APPROVED' ),
),
true // bypass caching
);
/*
* Dismiss any approving reviews.
*/
foreach( $pr_item_reviews as $pr_item_review ) {
vipgoci_github_pr_review_dismiss(
$options['repo-owner'],
$options['repo-name'],
(int) $pr_item->number,
(int) $pr_item_review->id,
'Dismissing obsolete review; not approved any longer',
$options['token']
);
}
vipgoci_runtime_measure( VIPGOCI_RUNTIME_STOP, 'vipgoci_auto_approval_non_approval' );
}
/**
* Approve a particular Pull-Request,
* alter label for the PR if needed,
* remove old comments, and log everything
* we do.
*
* Note that the testing of this function is
* covered by tests of vipgoci_auto_approval().
*
* @codeCoverageIgnore
*/
function vipgoci_autoapproval_do_approve(
$options,
$pr_item,
$pr_label,
&$auto_approved_files_arr,
$files_seen
) {
vipgoci_runtime_measure( VIPGOCI_RUNTIME_START, 'vipgoci_autoapproval_do_approve' );
$pr_item_approval_reviews =
vipgoci_github_pr_reviews_get(
$options['repo-owner'],
$options['repo-name'],
$pr_item->number,
$options['token'],
array(
'login' => 'myself',
'state' => array( 'APPROVED' )
),
true
);
if ( empty( $pr_item_approval_reviews ) ) {
vipgoci_counter_report(
VIPGOCI_COUNTERS_DO,
'github_pr_approval',
1
);
vipgoci_log(
( $options['dry-run'] === true
? 'Would ' : 'Will ' ) .
'auto-approve Pull-Request #' .
(int) $pr_item->number . ' ' .
'as it alters or creates ' .
'only files that can be ' .
'automatically approved' .
' -- PR URL: https://github.com/' .
rawurlencode( $options['repo-owner'] ) .
'/' .
rawurlencode( $options['repo-name'] ) .
'/pull/' .
(int) $pr_item->number . ' ',
array(
'repo_owner'
=> $options['repo-owner'],
'repo_name'
=> $options['repo-name'],
'pr_number'
=> (int) $pr_item->number,
'commit_id'
=> $options['commit'],
'dry_run'
=> $options['dry-run'],
'autoapprove-filetypes' =>
$options['autoapprove-filetypes'],
'auto_approved_files_arr' =>
$auto_approved_files_arr,
'files_seen' => $files_seen,
),
0,
true // Send to IRC
);
/*
* Actually approve, if not in dry-mode.
* Also add a label to the Pull-Request
* if applicable.
*/
vipgoci_github_approve_pr(
$options['repo-owner'],
$options['repo-name'],
$options['token'],
$pr_item->number,
$options['commit'],
'Auto-approved Pull-Request #' .
(int) $pr_item->number . ' as it ' .
'contains only auto-approvable files' .
' -- either pre-approved files _or_ file-types that are ' .
'auto-approvable (' .
implode(
', ',
array_map(
function( $type ) {
return '`' . $type . '`';
},
$options['autoapprove-filetypes']
)
) .
').',
$options['dry-run']
);
}
else {
vipgoci_log(
'Will not actually approve Pull-Request #' .
(int) $pr_item->number .
', as it is already approved by us',
array(
'repo_owner' =>
$options['repo-owner'],
'repo_name' =>
$options['repo-name'],
'pr_number' =>
$pr_item->number,
'commit_id'
=> $options['commit'],
'dry_run'
=> $options['dry-run'],
'autoapprove-filetypes' =>
$options['autoapprove-filetypes'],
'auto_approved_files_arr' =>
$auto_approved_files_arr,
'files_seen' =>
$files_seen,
),
0,
true
);
}
/*
* Add label to Pull-Request, but
* only if it is not associated already.
* If it is already associated, just log
* that fact.
*/
if ( false === $pr_label ) {
vipgoci_github_label_add_to_pr(
$options['repo-owner'],
$options['repo-name'],
$options['token'],
$pr_item->number,
$options['autoapprove-label'],
$options['dry-run']
);
}
else {
vipgoci_log(
'Will not add label to issue, ' .
'as it already exists',
array(
'repo_owner' =>
$options['repo-owner'],
'repo_name' =>
$options['repo-name'],
'pr_number' =>
$pr_item->number,
'label_name' =>
$options['autoapprove-label'],
)
);
}
/*
* Remove any comments indicating that a file is
* approved -- we want to get rid of these, as they
* are useless to reviewers at this point. The PR is
* approved anyway.
*/
vipgoci_log(
'Removing any previously submitted comments ' .
'indicating that a particular file ' .
'is approved as the whole ' .
'Pull-Request is approved',
array(
'pr_number' => $pr_item->number,
)
);
$pr_comments = vipgoci_github_pr_reviews_comments_get_by_pr(
$options,
$pr_item->number,
array(
'login' => 'myself',
)
);
foreach( $pr_comments as $pr_comment_item ) {
/*
* If we find the 'approved in hashes-to-hashes ...'
* message, we can safely remove the comment.
*/
if ( false !== strpos(
$pr_comment_item->body,
rtrim( VIPGOCI_FILE_IS_APPROVED_MSG, '.' )
) ) {
vipgoci_github_pr_reviews_comments_delete(
$options,
$pr_comment_item->id
);
}
}
vipgoci_runtime_measure( VIPGOCI_RUNTIME_STOP, 'vipgoci_autoapproval_do_approve' );
}
/*
* Process auto-approval(s) of the Pull-Request(s)
* involved with the commit specified.
*
* This function will attempt to auto-approve
* Pull-Request(s) that only alter files with specific
* file-type endings. If the PR only alters these kinds
* of files, the function will auto-approve them, and else not.
*
* Note that the --skip-folders argument is ignored
* in this function. This is intentional, because if this
* function did not ignore these folders, it might approve
* Pull-Requests containing files that are actually used
* in production and could contain dangerous code.
*/
function vipgoci_auto_approval(
$options,
&$auto_approved_files_arr,
&$results
) {
vipgoci_runtime_measure( VIPGOCI_RUNTIME_START, 'auto_approve_commit' );
vipgoci_log(
'Doing auto-approval',
array(
'repo_owner' => $options['repo-owner'],
'repo_name' => $options['repo-name'],
'commit_id' => $options['commit'],
'autoapprove' => $options['autoapprove'],
'autoapproved_files_arr' =>
$auto_approved_files_arr,
)
);
$prs_implicated = vipgoci_github_prs_implicated(
$options['repo-owner'],
$options['repo-name'],
$options['commit'],
$options['token'],
$options['branches-ignore']
);
foreach ( $prs_implicated as $pr_item ) {
$pr_diff = vipgoci_github_diffs_fetch(
$options['repo-owner'],
$options['repo-name'],
$options['token'],
$pr_item->base->sha,
$options['commit'],
true, // include renamed files
true, // include removed files
true // include permission changes
);
$did_foreach = false;
$can_auto_approve = true;
$files_seen = array();
/*
* Loop through all files that are
* altered by the Pull-Request, look for
* files that can be auto-approved.
*/
foreach( $pr_diff as
$pr_diff_file_name => $pr_diff_contents
) {
$did_foreach = true;
$files_seen[] = $pr_diff_file_name;
/*
* Is file in array of files
* that can be auto-approved?
* If not, we cannot auto-approve.
*/
if ( ! isset(
$auto_approved_files_arr[
$pr_diff_file_name
]
) ) {
$can_auto_approve = false;
break;
}
}
/*
* Get label associated, but
* only our auto-approved one
*/
$pr_label = vipgoci_github_labels_get(
$options['repo-owner'],
$options['repo-name'],
$options['token'],
(int) $pr_item->number,
$options['autoapprove-label'],
true
);
if ( false == $did_foreach ) {
vipgoci_log(
'No action taken with Pull-Request #' .
(int) $pr_item->number . ' ' .
'since no files were found' .
' -- PR URL: https://github.com/' .
rawurlencode( $options['repo-owner'] ) .
'/' .
rawurlencode( $options['repo-name'] ) .
'/pull/' .
(int) $pr_item->number . ' ',
array(
'auto_approved_files_arr' =>
$auto_approved_files_arr,
'files_seen' => $files_seen,
'pr_number' => (int) $pr_item->number,
'pr_diff' => $pr_diff,
),
0,
true
);
}
else if (
( true === $did_foreach ) &&
( false === $can_auto_approve )
) {
vipgoci_auto_approval_non_approval(
$options,
$results,
$pr_item,
$pr_label,
$auto_approved_files_arr,
$files_seen,
array_keys( $pr_diff )
);
}
else if (
( true === $did_foreach ) &&
( true === $can_auto_approve )
) {
vipgoci_autoapproval_do_approve(
$options,
$pr_item,
$pr_label,
$auto_approved_files_arr,
$files_seen
);
}
unset( $files_seen );
}
/*
* Reduce memory-usage as possible
*/
unset( $pr_diff );
unset( $pr_diff_file_name );
unset( $pr_diff_contents );
unset( $pr_item );
unset( $pr_label );
unset( $prs_implicated );
unset( $files_seen );
unset( $did_foreach );
unset( $can_auto_approve );
gc_collect_cycles();
vipgoci_runtime_measure( VIPGOCI_RUNTIME_STOP, 'auto_approve_commit' );
}