Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup after ETH contract flow #4343

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Cleanup after ETH contract flow #4343

merged 5 commits into from
Nov 19, 2024

Commits on Nov 19, 2024

  1. refactor(core): use warning_hi_prio in ETH flow 

    Commit c300576 introduced the
`default_cancel` parameter to `show_warning` and `confirm_blob` rather
using the already existing `flow_warning_hi_prio` which was doing the
same thing. This commit reverts all the nonsense.

[no changelog]
    @ibz
    ibz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    06ec5b6 View commit details
    Browse the repository at this point in the history

  2. fix(core): fix crash caused by marquee 

    request_anim_frame will register a timer for RequestPaint, which will
then cause a crash. This commit fixes the crash, but makes the marquee
component not work.

[no changelog]
    @ibz
    ibz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    987768c View commit details
    Browse the repository at this point in the history

  3. refactor(core): drop confirm_blob_with_optional_pagination 

    Commit c300576 introduced
`confirm_blob_with_optional_pagination` which proved to be unpopular and
impractical. This commit brings back the old behaviour of having the
`ask_pagination` parameter on `confirm_blob`. It also reverts back to
using the old way of paginating `confirm_blob` on model R, which the
aforementioned commit ignored and re-implemented from scratch.

[no changelog]
    @ibz
    ibz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c80b2da View commit details
    Browse the repository at this point in the history

  4. refactor(core): get rid of description_font_green 

    [no changelog]
    @ibz
    ibz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    055343d View commit details
    Browse the repository at this point in the history

  5. chore(core): update fixtures

    @ibz
    ibz committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    69d448f View commit details
    Browse the repository at this point in the history