Abstraction of cache and context #4357
Open
+1,309
−956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
M1nd3r
force-pushed
the
M1nd3r/cache-and-context
branch
2 times, most recently
from
dbaba59
to
9400f19
Compare
[no changelog]
M1nd3r
force-pushed
the
M1nd3r/cache-and-context
branch
2 times, most recently
from
545adf2
to
48f58b0
Compare
M1nd3r
changed the title
M1nd3r
force-pushed
the
M1nd3r/cache-and-context
branch
2 times, most recently
from
addd607
to
3411ee1
Compare
[no changelog]
[no changelog]
M1nd3r
force-pushed
the
M1nd3r/cache-and-context
branch
from
3411ee1
to
f51e6dc
Compare
M1nd3r
changed the title
M1nd3r
commented
Nov 18, 2024
| @@ -557,6 +557,7 @@ if FROZEN: | |||
| )) | |||
|
|
|||
| SOURCE_PY.extend(Glob(SOURCE_PY_DIR + 'trezor/wire/*.py')) | |||
| SOURCE_PY.extend(Glob(SOURCE_PY_DIR + 'trezor/wire/codec/*.py')) | |||
There was a problem hiding this comment.
The codec specific files are separated so that they can be easily ommited for THP prod builds. When the THP implementation is added, it could look like this:
if THP:
SOURCE_PY.extend(Glob(SOURCE_PY_DIR + 'trezor/wire/thp/*.py'))
if not THP or PYOPT == '0':
SOURCE_PY.extend(Glob(SOURCE_PY_DIR + 'trezor/wire/codec/*.py'))
There was a problem hiding this comment.
Note: The condition or PYOPT == '0' is in the snippet because the codec will be used on DebugLink even with THP builds.
M1nd3r
requested review from
matejcik,
andrewkozlik,
onvej-sl and
prusnak
as code owners
M1nd3r
commented
Nov 18, 2024
M1nd3r
commented
Nov 18, 2024
…wnClass [no changelog]
M1nd3r
commented
Nov 19, 2024
mmilata
reviewed
Nov 19, 2024
| Filter = Callable[[int, Handler], Handler] | ||
|
|
||
| # If set to False protobuf messages marked with "experimental_message" option are rejected. | ||
| EXPERIMENTAL_ENABLED = False |
There was a problem hiding this comment.
Note to self: shouldn't this also be somewhere under storage/cache to avoid being wiped by a restart?
[no changelog]
M1nd3r
commented
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstraction of cache and context so that the current codec_v1 implementation can be switched for THP version.