Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/mercury): tap to cancel UX #4384

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

obrusvit
Copy link
Contributor

flow_confirm_output behaved wrong in "Cancel" screen which is followed by "Tap to cancel" screen. The swipe settings was not aligned with the handle_swipe implementation.

@obrusvit obrusvit added the T3T1 label Nov 25, 2024
@obrusvit obrusvit self-assigned this Nov 25, 2024
Base automatically changed from matejcik/fix-cancel-crash to main November 25, 2024 18:15
@matejcik matejcik requested review from ibz and removed request for prusnak and ibz November 25, 2024 18:17
- fixed UI bug in tap to cancel screen of `flow_confirm_output`

[no changelog]
Copy link

legacy UI changes device test(screens) main(screens)

Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@matejcik matejcik merged commit 8a2a381 into main Nov 26, 2024
95 checks passed
@matejcik matejcik deleted the obrusvit/fix-tap-to-cancel branch November 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants