Introduce show_danger #4404
Open
Introduce show_danger #4404
+111
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8 tasks
ibz
force-pushed
the
ibz/20241128-danger
branch
from
135f9b0
to
d8d236e
Compare
This is a unified interface for flow_warning_hi_prio, which was available only on Mercury before. [no changelog]
ibz
force-pushed
the
ibz/20241128-danger
branch
from
d8d236e
to
cba2e08
Compare
obrusvit
reviewed
Nov 29, 2024
| @@ -22,13 +22,13 @@ use super::super::{ | |||
| }; | |||
|
|
|||
| #[derive(Copy, Clone, PartialEq, Eq)] | |||
| pub enum WarningHiPrio { | |||
| pub enum Danger { | |||
There was a problem hiding this comment.
I's slightly prefer naming this ShowDanger and also the file should be show_danger.rs.
For consistency.
| def show_danger( | ||
| br_name: str, | ||
| content: str, | ||
| content_short: str | None = None, |
There was a problem hiding this comment.
I don't think the distinction between content/content_short is a good idea. I think we can keep the confirm_ethereum_unknown_contract_warning function which calls the show_danger with the appropriate string.
| br_code: ButtonRequestType = ButtonRequestType.Warning, | ||
| ) -> Awaitable[None]: | ||
| if content_short is None: | ||
| content_short = content |
There was a problem hiding this comment.
apart from the previous comment, why showing content_short on TT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a unified interface for
flow_warning_hi_prio, which was available only on Mercury before.