Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong configuration option name for mapping origins #21

Open
hazmei opened this issue Dec 8, 2022 · 0 comments
Open

Wrong configuration option name for mapping origins #21

hazmei opened this issue Dec 8, 2022 · 0 comments

Comments

@hazmei
Copy link

hazmei commented Dec 8, 2022

Hi there!

I just noticed that the option name for defining the largest byte size an object may be before it's unreachable differs between

helm-charts/charts/trickster/templates/configmap.yaml

Lines 259 to 261 in 334a313

{{- if .maxObjectByteSize }}
max_object_byte_size = {{ .maxObjectByteSize }}
{{- end }}
and https://github.com/trickstercache/trickster/blob/4595bd6a1ae1165ef497251ad85c646dadc8a925/cmd/trickster/conf/example.conf#L339.

Should this be max_object_size_bytes or max_object_byte_size?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hazmei