Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anasazi: create GeneralizedDavidson Tpetra tests #12345

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cwschilly
Copy link
Contributor

@trilinos/anasazi
@hkthorn

Motivation

This PR creates the following tests in the tpetra/test/GeneralizedDavidson directory:

  • cxx_main_nh.cpp
  • cxx_main.cpp
  • cxx_main_lap.cpp

cxx_main_nh.cpp is modeled after the current test in the Epetra test directory (basically a one-to-one conversion, changing E's to T's)

cxx_main.cpp and cxx_main_lap.cpp are modeled after the tests of other solvers in the Tpetra test directory. Since the GeneralizedDavidson solver does not support complex types, cxx_main.cpp uses the same logic as the cxx_main_complex.cpp tests for the other solvers, but uses ST=double instead.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

Copy link
Contributor

@hkthorn hkthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix cxx_main.cpp test to replicate anasazi/epetra/test/GeneralizedDavidson/cxx_main.cpp test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my understanding that the mhd1280b.cua file contains a complex-valued matrix stored as interleaved doubles, so it's not useful for this test. Since the Generalized Davidson solver only works for real scalar types, this test should replicate the anasazi/epetra/test/GeneralizedDavidson/cxx_main.cpp test instead of the other cxx_main.cpp tests in the Tpetra directory.

@jwillenbring
Copy link
Member

@hkthorn So you are saying that this test should be modeled after a different existing test?

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants