Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: B hint not showing at start of line #50

Closed
josh-nz opened this issue Jun 1, 2024 · 6 comments · Fixed by #53
Closed

bug: B hint not showing at start of line #50

josh-nz opened this issue Jun 1, 2024 · 6 comments · Fixed by #53
Milestone

Comments

@josh-nz
Copy link
Contributor

josh-nz commented Jun 1, 2024

Screen Shot 2024-06-01 at 16 49 22

In this screenshot, the first character v should be hinted by B.

I've submitted a pull request with a possible fix.

@willothy
Copy link
Collaborator

willothy commented Jun 1, 2024

Hmm I don't see your PR for this - or is the fix in your other open PR?

@josh-nz
Copy link
Contributor Author

josh-nz commented Jun 1, 2024

Still getting there, have a merge conflict to resolve. Won't be too long.

@willothy
Copy link
Collaborator

willothy commented Jun 1, 2024

Sorry, no rush! Just thought you meant you'd already submitted it :)

@josh-nz
Copy link
Contributor Author

josh-nz commented Jun 1, 2024

I perhaps should have submitted the PR and then mentioned I had submitted it. Wasn't expecting a) the merge conflict and b) a super fast turn around!

@willothy
Copy link
Collaborator

willothy commented Jun 1, 2024

Haha yeah, just happened to be working on this at the same time! No worries, I have done the same

@josh-nz
Copy link
Contributor Author

josh-nz commented Jun 1, 2024

PR made, #53

@tris203 tris203 added this to the 1.0.0 milestone Jun 1, 2024
@tris203 tris203 closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants