Prevent infinite loop in initial AMR

[benegee]

When allowing both initial refinement and coarsening, and depending on threshold values, the initialization loop

Trixi.jl/src/callbacks_step/amr.jl

Lines 137 to 141 in 01032aa

	@trixi_timeit timer() "initial condition AMR" if amr_callback.adapt_initial_condition
	# iterate until mesh does not change anymore
	has_changed = amr_callback(integrator,
	only_refine = amr_callback.adapt_initial_condition_only_refine)
	while has_changed

might just run forever. Prevent this by aborting after 10 iterations.

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.30%. Comparing base (01032aa) to head (bd81931).

Files	Patch %	Lines
src/callbacks_step/amr.jl	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
- Coverage   96.31%   96.30%   -0.01%     
==========================================
  Files         440      440              
  Lines       35797    35802       +5     
==========================================
+ Hits        34476    34479       +3     
- Misses       1321     1323       +2     

Flag	Coverage Δ
unittests	96.30% <60.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ranocha]

Thanks!

[benegee]

Thanks for merging!