Code-Smells.md

Code Smells

Smells are indicators of where your code might be hard to read, maintain or evolve, rather than things that are specifically wrong. Naturally this means that Reek is looking towards your code's future (and that can make its reports seem somewhat subjective, of course).

Reek currently includes checks for the following smells:

• Attribute
• Class Variable
• Control Couple, including
  • Boolean Parameter
  • Control Parameter
• Data Clump
• Duplicate Method Call
• Instance Variable Assumption
• Irresponsible Module
• Large Class, including
  • Too Many Constants
  • Too Many Instance Variables
  • Too Many Methods
• Long Parameter List, and its special case Long Yield List
• Low Cohesion, including
  • Feature Envy
  • Utility Function
• Module Initialize
• Nested Iterators
• Missing Safe Method, formerly known as Prima Donna Method
• Simulated Polymorphism, including
  • Manual Dispatch
  • Nil Check
  • Repeated Conditional
• Subclassed From Core Class
• Too Many Statements
• Uncommunicative Name, including
  • Uncommunicative Method Name
  • Uncommunicative Module Name
  • Uncommunicative Parameter Name
  • Uncommunicative Variable Name
• Unused Parameters
• Unused Private Method