Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop '--enable-static' configure option, broken with too much maint overhead #368

Open
az143 opened this issue Sep 21, 2023 · 5 comments
Open
Milestone

Comments

@az143
Copy link

az143 commented Sep 21, 2023

that's with the code from git, head at efed0db.
./autogen.sh, ./configure --enable-static and make results in a fully dynamic finit

$ ldd ./src/finit
	linux-vdso.so.1 (0x00007ffe7f358000)
	libite.so.5 => /lib/x86_64-linux-gnu/libite.so.5 (0x00007f6d2e7ef000)
	libuev.so.2 => /lib/x86_64-linux-gnu/libuev.so.2 (0x00007f6d2e7e8000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f6d2e614000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f6d2e855000)

trying to force this a bit harder with ./configure --enable-static=yes --enable-shared=no doesn't get me anywhere either:

$ make 
...
Making all in plugins
make[2]: Entering directory '/tmp/finitupstream/finit/plugins
...
  CCLD     libplug.la
libtool:   error: cannot build a shared library See the libtool documentation for more information. Fatal configuration error.
@troglobit
Copy link
Owner

This support was requested over 10 years ago and should probably be dropped since I have no interest in maintaining something I don't use and which also makes maintenance of Finit quite a lot more difficult.

Thanks for reminding me, I'll put this up for removal in v5.0

@troglobit troglobit added this to the 5.0 milestone Sep 21, 2023
@az143
Copy link
Author

az143 commented Sep 21, 2023 via email

@troglobit
Copy link
Owner

troglobit commented Sep 21, 2023

fair enough. i hope you won't categorically rule out a return, if i do manage to resurrect that feature at some point in the future? regards az

Well, that depends. Getting it to work is one thing, but since Finit evolves and more code is added, other parts refactored, it just adds drag. I've spent way too much time maintaining all the compatibility functions and trying to test this myself, so that's what I'd like to see go, the overhead. But if you want to stick around supporting the static builds for the long haul you're of course welcome to do so.

@troglobit troglobit changed the title --enable-static no longer works Drop '--enable-static' configure option, broken with too much maint overhead Oct 15, 2023
@vazub
Copy link

vazub commented Dec 10, 2023

Please don't drop. I am building statically linked distro and can compile Finit just fine with Zig/musl.

@troglobit
Copy link
Owner

Please don't drop. I am building statically linked distro and can compile Finit just fine with Zig/musl.

Great, now you're team that can help out maintaining this. Looking forward to the collaboration.

(I'm being both a bit sarcastic and genuine here. If you want a less used feature to remain, I will no longer do the job for you, you will have to step up.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants