Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a message when user tries to upgrade app with db from a stopped state #1708

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Nov 6, 2023

Closes #1687

If a user tries to upgrade an app with database from a stopped state, the DB will not be reachable, so we should block early the upgrade, because the backup job will not be able to complete and will result to a timeout.

Alternatives are:

  • Skip the backup completely.
  • Start the database inside the backup job. (I 'm not a fan of spinning processes in the background in the same container.)

https://ixsystems.atlassian.net/browse/TNCHARTS-324

@stavros-k stavros-k self-assigned this Nov 6, 2023
@stavros-k stavros-k requested review from Qubad786 and sonicaj November 6, 2023 14:15
@stavros-k stavros-k marked this pull request as ready for review November 6, 2023 14:17
@stavros-k stavros-k merged commit 15008d3 into master Nov 8, 2023
23 checks passed
@stavros-k stavros-k deleted the msg-backup branch November 20, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immich upgrade always fails with "timed out waiting for the condition"
2 participants