-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD-1626 / 25.04 / Pd 1626 nextcloud app tutorial improvements #3326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the characters not allowed in Redis passwords, and clarifies information about the TrueNAS users added as an administrator for the app, and adds content linking this article to with the Nextcloud plugin article in /solutions/integrations/nextcloud.md article. It updates the content in two snippet files.
This commit creates a new snippet BeforeYouBeginAddAppDatasets.md for the create dataset bullet point, and removes the add user and add dataset bullet points from the BeforeYouBeginStableApps.,md snippet. It adds html code for indented paragraphs with the <dif></dif> tags to get the expand to indent, and replaces the markdown emphasis with HTML tags. It updates the Plex tutorial to use the new snippet.
bugclerk
changed the title
Pd 1626 nextcloud app tutorial improvements
PD-1626 / 25.04 / Pd 1626 nextcloud app tutorial improvements
Dec 2, 2024
This commit adds the new BeforeYouBeginRunAsUser.md snippet, and reorganizes the Before You Begin section.
This commit adds the warning about using an encrypted pool to the BeforeYouBeginStableApps.md snippet
This commit updates the content in the Nextcloud and Plex tutorials, and copies the changes made in to snippets the PR for PD-1478.
Pushed changes to the Nextcloud and Plex tutorials, and changes made to snippets in the PR for PD-1478 into this PR. |
tonyriv3
added
the
Technical Writer Review (TR)
A technical writer is reviewing the PR.
label
Dec 9, 2024
tonyriv3
approved these changes
Dec 9, 2024
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the InstallNextcloudApp.md tutorial with two content improvements in tickets PD-1626 and PD-1616.
It reworks the BeforeYouBeginStableApps.md snippet to only include one bullet point for adding the app pool, and moves the bullet point to create a dataset to a new snippet BeforeYouBeginAddAppDatasets.md, and removes the bullet point to add a user as it duplicates another snippet BeforeYouBeginAddAppUser.md.
It changes the indent paragraph HTML tags to tags that indent several paragraphs and an expand shortcode area. All markdown tags are converted to HTML tags for them to render correctly.
It makes the snippet changes to the PlexApp.md tutorial.
It also makes corrections to the content about the /solutions/integrations/nextcloud.md file.
Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.