Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-1626 / 25.04 / Pd 1626 nextcloud app tutorial improvements #3326

Merged
merged 10 commits into from
Dec 9, 2024

Conversation

micjohnson777
Copy link
Contributor

This PR updates the InstallNextcloudApp.md tutorial with two content improvements in tickets PD-1626 and PD-1616.
It reworks the BeforeYouBeginStableApps.md snippet to only include one bullet point for adding the app pool, and moves the bullet point to create a dataset to a new snippet BeforeYouBeginAddAppDatasets.md, and removes the bullet point to add a user as it duplicates another snippet BeforeYouBeginAddAppUser.md.

It changes the indent paragraph HTML tags to tags that indent several paragraphs and an expand shortcode area. All markdown tags are converted to HTML tags for them to render correctly.

It makes the snippet changes to the PlexApp.md tutorial.

It also makes corrections to the content about the /solutions/integrations/nextcloud.md file.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This commit adds the characters not allowed in Redis passwords, and clarifies information about the TrueNAS users added as an administrator for the app, and adds content linking this article to with the Nextcloud plugin article in /solutions/integrations/nextcloud.md article.
It updates the content in two snippet files.
This commit creates a new snippet BeforeYouBeginAddAppDatasets.md for the create dataset bullet point, and removes the add user and add dataset bullet points from the BeforeYouBeginStableApps.,md snippet.
It adds html code for indented paragraphs with the <dif></dif> tags to get the expand to indent, and replaces the markdown emphasis with HTML tags.
It updates the Plex tutorial to use the new snippet.
@micjohnson777 micjohnson777 requested a review from a team as a code owner December 2, 2024 21:09
@bugclerk bugclerk changed the title Pd 1626 nextcloud app tutorial improvements PD-1626 / 25.04 / Pd 1626 nextcloud app tutorial improvements Dec 2, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

@micjohnson777 micjohnson777 marked this pull request as draft December 5, 2024 13:03
This commit adds the new BeforeYouBeginRunAsUser.md snippet, and reorganizes the Before You Begin section.
This commit adds the warning about using an encrypted pool to the BeforeYouBeginStableApps.md snippet
This commit updates the content in the Nextcloud and Plex tutorials, and copies the changes made in to snippets the PR for PD-1478.
@micjohnson777 micjohnson777 marked this pull request as ready for review December 5, 2024 19:11
@micjohnson777
Copy link
Contributor Author

Pushed changes to the Nextcloud and Plex tutorials, and changes made to snippets in the PR for PD-1478 into this PR.

@tonyriv3 tonyriv3 added the Technical Writer Review (TR) A technical writer is reviewing the PR. label Dec 9, 2024
@tonyriv3 tonyriv3 merged commit 7505348 into master Dec 9, 2024
3 checks passed
@tonyriv3 tonyriv3 deleted the PD-1626-Nextcloud-App-Tutorial-Improvements branch December 9, 2024 18:40
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Technical Writer Review (TR) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants