Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-1478 / 25.04 / Pd 1478 update netdata tutorial #3337

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

micjohnson777
Copy link
Contributor

This PR updates the Netdata app tutorial to the current template and with updated screenshots.
It copies the BeforeYouBeginAddAppDatasets.md snippet into this PR, and it adjusts the content. Changes need to be added to another open PR to avoid conflicts.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This commit updates the Netdata app and web portal screenshots, and updates the tutorial content to the current template and instructions.
Need to add the BeforeYouBeginAddAppDataset.md snippet to this PR. Copy if from the PR for PD-1626
This commit fixes calls to snippet files,fixes internal turtorial links, and adds links to SCALE articles on permissions and the Edit ACL sreen.
@micjohnson777 micjohnson777 requested a review from a team as a code owner December 4, 2024 22:03
@micjohnson777 micjohnson777 marked this pull request as draft December 4, 2024 22:03
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

@bugclerk bugclerk changed the title Pd 1478 update netdata tutorial PD-1478 / 25.04 / Pd 1478 update netdata tutorial Dec 4, 2024
This commit removes duplicated text, adds the new BeforeYouBeginRunAsUser.md snippet, and renames a few headings.
@micjohnson777 micjohnson777 marked this pull request as ready for review December 5, 2024 15:50
micjohnson777 and others added 5 commits December 5, 2024 10:51
This commit updates the content to include an admonition about using encrypted pools for apps.
This commit removes the image from BeforeYouBeginRunAsUser.md and puts the image in the article content.
Moved dataset encryption warning to this snippet
Remove encrypted pool admonition
@micjohnson777
Copy link
Contributor Author

Edited the two snippets, BeforeYouBeginStableApps.md to remove the encrypted pool admonition, and added a modified admonition about encrypted datasets to BeforeYouBeginAddAppDatasets.md

@micjohnson777
Copy link
Contributor Author

Conflicts resolved

@DjP-iX DjP-iX removed the Re-Review label Dec 11, 2024
@linzi-ix linzi-ix added the Technical Writer Review (LM) A technical writer is reviewing the PR. label Dec 11, 2024
@linzi-ix linzi-ix merged commit 1484bdf into master Dec 11, 2024
3 checks passed
@linzi-ix linzi-ix deleted the PD-1478-Update-Netdata-Tutorial branch December 11, 2024 20:57
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Technical Writer Review (LM) A technical writer is reviewing the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants