NAS-133026 / 25.04 / Fix crash when handling job locks with invalid call arguments

src/middlewared/middlewared/job.py

@@ -369,7 +369,12 @@ def check_pipe(self, pipe):
     def get_lock_name(self):
         lock_name = self.options.get('lock')
         if callable(lock_name):
-            lock_name = lock_name(self.args)
+            try:
+                lock_name = lock_name(self.args)
+            except Exception:
+                self.middleware.logger.error("Error handling job lock", exc_info=True)
+                raise CallError("Error handling job lock. This is most likely caused by invalid call arguments.",
+                                errno.EINVAL)
         return lock_name
 
     def set_id(self, id_):

src/middlewared/middlewared/plugins/apps/crud.py

@@ -177,7 +177,7 @@ async def convert_to_custom(self, job, app_name):
             Str('version', default='latest'),
         )
     )
-    @job(lock=lambda args: f'app_create_{args[0]["app_name"]}')
+    @job(lock=lambda args: f'app_create_{args[0].get("app_name")}')
     def do_create(self, job, data):
         """
         Create an app with `app_name` using `catalog_app` with `train` and `version`.

src/middlewared/middlewared/plugins/pool_/dedup.py

@@ -9,7 +9,7 @@ class Config:
         cli_namespace = 'storage.pool'
 
     @api_method(DDTPruneArgs, DDTPruneResult)
-    @job(lock=lambda args: f'ddt_prune_{args[0]["pool_name"]}')
+    @job(lock=lambda args: f'ddt_prune_{args[0].get("pool_name")}')
     async def ddt_prune(self, job, options):
         """
         Prune DDT entries in pool `pool_name` based on the specified options.