-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131796 / 25.04 / Fix styles for ix-code-editor
#11105
Conversation
ix-code-editor
ix-code-editor
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11105 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 1648 1648
Lines 57925 57926 +1
Branches 5947 5947
=======================================
+ Hits 47728 47729 +1
Misses 10197 10197 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I tested it out and found problems, see the video:
Screen.Recording.2024-11-28.at.08.54.27.mov
@AlexKarpov98 This is just means to provide very basic help as a code editor. This editor is for yml language. There's no syntax highlighting available for yml config. I've added support for enter and undo commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been merged and conversations have been locked. |
Changes:
Changes theme. But doesn't change much visually.
Testing:
Test the custom app yaml form. You should see some code editor styles. Line numbers and changed background color.