Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131796 / 25.04 / Fix styles for ix-code-editor #11105

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

RehanY147
Copy link
Contributor

Changes:

Changes theme. But doesn't change much visually.

Testing:

Test the custom app yaml form. You should see some code editor styles. Line numbers and changed background color.

@RehanY147 RehanY147 requested a review from a team as a code owner November 27, 2024 23:50
@RehanY147 RehanY147 requested review from undsoft and removed request for a team November 27, 2024 23:50
@bugclerk bugclerk changed the title NAS-131796: Fix styles for ix-code-editor NAS-131796 / 25.04 / Fix styles for ix-code-editor Nov 27, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (6bd5eda) to head (9fac77d).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11105   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files        1648     1648           
  Lines       57925    57926    +1     
  Branches     5947     5947           
=======================================
+ Hits        47728    47729    +1     
  Misses      10197    10197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I tested it out and found problems, see the video:

Screen.Recording.2024-11-28.at.08.54.27.mov

@undsoft undsoft removed their request for review November 28, 2024 08:22
@RehanY147
Copy link
Contributor Author

@AlexKarpov98 This is just means to provide very basic help as a code editor. This editor is for yml language. There's no syntax highlighting available for yml config. I've added support for enter and undo commands

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works smoothly now.

I'd like to see some syntax highlighting though, like in VS code for example.
VS code:
Screenshot 2024-12-01 at 13 52 03

WebUI:
Screenshot 2024-12-01 at 13 53 06

@RehanY147 RehanY147 enabled auto-merge (squash) December 4, 2024 00:04
@RehanY147 RehanY147 merged commit 1e0dd8e into master Dec 4, 2024
11 checks passed
@RehanY147 RehanY147 deleted the NAS-131796 branch December 4, 2024 00:34
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants