Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132675 / 25.04 / Remove nvidia state and event handlers (by undsoft) #11132

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Dec 3, 2024

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 8936d21a7c3a381bba3f2c167191f3403d47b866

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x b157439e194f2a8d6ffb0a8d482ab91143c44337

Testing:

There is no suitable machine for testing, but you can create an Electric Eel machine and update AppsSettingsComponent to have protected hasNvidiaCard$ = of(true);

Original PR: #11126
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132675

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (f93e825) to head (9f77abb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11132      +/-   ##
==========================================
- Coverage   82.39%   82.39%   -0.01%     
==========================================
  Files        1648     1647       -1     
  Lines       57926    57895      -31     
  Branches     5950     5945       -5     
==========================================
- Hits        47729    47703      -26     
+ Misses      10197    10192       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	src/assets/i18n/cs.json
#	src/assets/i18n/es-ar.json
#	src/assets/i18n/fr.json
#	src/assets/i18n/nl.json
@undsoft undsoft marked this pull request as ready for review December 4, 2024 08:31
@undsoft undsoft requested a review from a team as a code owner December 4, 2024 08:31
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team December 4, 2024 08:31
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backported

@undsoft undsoft enabled auto-merge (squash) December 4, 2024 08:32
@undsoft undsoft merged commit 1d33b2f into master Dec 4, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132675-25.04 branch December 4, 2024 08:58
@bugclerk
Copy link
Contributor Author

bugclerk commented Dec 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants