Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131831 / 24.10.2 / Replace images for H series (by bvasilenko) #11139

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Dec 4, 2024

Changes:

Image change

Testing:

  1. Simulate H-series enclosure with environment config

  2. Go to Dashboard , see System Info widget

    Expected image: see the one provided in the ticket

Original PR: #11129
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131831

@bugclerk bugclerk requested a review from a team as a code owner December 4, 2024 06:15
@bugclerk bugclerk requested review from RehanY147 and removed request for a team December 4, 2024 06:15
Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests are failing though

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@b157439). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11139   +/-   ##
=====================================================
  Coverage                      ?   79.95%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51436           
  Branches                      ?     5934           
=====================================================
  Hits                          ?    41125           
  Misses                        ?    10311           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@bvasilenko bvasilenko merged commit 0d8c575 into stable/electriceel Dec 11, 2024
7 checks passed
@bvasilenko bvasilenko deleted the NAS-131831-24.10.2 branch December 11, 2024 06:42
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants