Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132783 / 25.04 / Improve master-detail-view #11140

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

bvasilenko
Copy link
Contributor

Testing:

Please see ticket for the list of expected results

@bvasilenko bvasilenko requested a review from a team as a code owner December 4, 2024 06:45
@bvasilenko bvasilenko requested review from denysbutenko and removed request for a team December 4, 2024 06:45
@bugclerk bugclerk changed the title NAS-132783: Improve master-detail-view NAS-132783 / 25.04 / Improve master-detail-view Dec 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (5e28742) to head (7bdac72).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11140      +/-   ##
==========================================
- Coverage   82.42%   82.39%   -0.03%     
==========================================
  Files        1649     1647       -2     
  Lines       58011    57898     -113     
  Branches     5957     5945      -12     
==========================================
- Hits        47814    47706     -108     
+ Misses      10197    10192       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It looks good. Lets do alignment of left header section to be same line with right header section.

@bvasilenko bvasilenko merged commit a17536c into master Dec 5, 2024
9 checks passed
@bvasilenko bvasilenko deleted the NAS-132783 branch December 5, 2024 06:18
@bugclerk
Copy link
Contributor

bugclerk commented Dec 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants