Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132887 / 25.04 / Migrate more inputs to signals #11144

Merged
merged 2 commits into from
Dec 5, 2024

NAS-132887: Migrate more inputs to signals

2572539
Select commit
Loading
Failed to load commit list.
Merged

NAS-132887 / 25.04 / Migrate more inputs to signals #11144

NAS-132887: Migrate more inputs to signals
2572539
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

82.39% (+0.00%) compared to 05a0c9d

View this Pull Request on Codecov

82.39% (+0.00%) compared to 05a0c9d

Details

Codecov Report

Attention: Patch coverage is 80.80000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (05a0c9d) to head (2572539).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tives/tree-virtual-scroll-node-outlet.directive.ts 0.00% 7 Missing ⚠️
...ader/components/app-loader/app-loader.component.ts 0.00% 3 Missing ⚠️
...-selection-vdev/manual-selection-vdev.component.ts 0.00% 3 Missing ⚠️
...ponents/general-dialog/general-dialog.component.ts 33.33% 2 Missing ⚠️
src/app/modules/dialog/dialog.service.ts 33.33% 2 Missing ⚠️
src/app/modules/loader/app-loader.service.ts 0.00% 2 Missing ⚠️
...tials-select/cloud-credentials-select.component.ts 85.71% 1 Missing ⚠️
...ynamic-form-item/ix-dynamic-form-item.component.ts 85.71% 1 Missing ⚠️
...ms/components/ix-combobox/ix-combobox.component.ts 92.30% 1 Missing ⚠️
...ules/ix-table/directives/ix-body-cell.directive.ts 85.71% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11144   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files        1647     1647           
  Lines       57900    57960   +60     
  Branches     5945     5950    +5     
=======================================
+ Hits        47708    47759   +51     
- Misses      10192    10201    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov