Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132999 / 25.04 / Remove Netdata UI #11167

Merged
merged 3 commits into from
Dec 13, 2024
Merged

NAS-132999 / 25.04 / Remove Netdata UI #11167

merged 3 commits into from
Dec 13, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 11, 2024

Changes:

Removes the button to open Netdata as requested because of STIG requirements.

Testing:
Code review.

@undsoft undsoft requested a review from a team as a code owner December 11, 2024 08:52
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team December 11, 2024 08:52
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-132999: Remove Netdata UI NAS-132999 / 25.04 / Remove Netdata UI Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (c06f5c3) to head (3ad3059).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/cloud-backup-form/cloud-backup-form.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11167      +/-   ##
==========================================
- Coverage   82.69%   82.67%   -0.02%     
==========================================
  Files        1652     1651       -1     
  Lines       58317    58280      -37     
  Branches     5997     5998       +1     
==========================================
- Hits        48223    48182      -41     
- Misses      10094    10098       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@undsoft undsoft merged commit 84cee55 into master Dec 13, 2024
10 of 11 checks passed
@undsoft undsoft deleted the NAS-132999 branch December 13, 2024 08:37
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants