Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133028 / 25.04 / Enable @angular-eslint/prefer-signals #11170

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 11, 2024

Testing:

Test for regressions.

@undsoft undsoft requested a review from a team as a code owner December 11, 2024 17:15
@undsoft undsoft requested review from RehanY147 and removed request for a team December 11, 2024 17:15
@bugclerk bugclerk changed the title NAS-133028: Enable @angular-eslint/prefer-signals NAS-133028 / 25.04 / Enable @angular-eslint/prefer-signals Dec 11, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (3f625f8) to head (f19930e).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ponents/ix-table-pager/ix-table-pager.component.ts 66.66% 4 Missing ⚠️
...ynamic-form-item/ix-dynamic-form-item.component.ts 92.30% 1 Missing ⚠️
...omponents/ix-table-body/ix-table-body.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11170      +/-   ##
==========================================
+ Coverage   82.68%   82.69%   +0.01%     
==========================================
  Files        1652     1652              
  Lines       58334    58360      +26     
  Branches     6000     6001       +1     
==========================================
+ Hits        48235    48263      +28     
+ Misses      10099    10097       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 3490c7c into master Dec 13, 2024
9 checks passed
@undsoft undsoft deleted the NAS-133028 branch December 13, 2024 08:37
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants