Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132785 / 25.10 / Use cdkDragList for dashboard widgets #11176

Open
wants to merge 2 commits into
base: NAS-132636
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

  • Fixes dashboard drag and drop. Requires Angular 19.
  • Use cdkDragList and cdkDropListOrientation="mixed"
  • Remove ixDragList module

Testing:

  • Try to drag and drop widgets on main dashboard.

@denysbutenko denysbutenko requested a review from a team as a code owner December 12, 2024 18:25
@denysbutenko denysbutenko requested review from bvasilenko and removed request for a team December 12, 2024 18:25
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title Nas 132785 NAS-132785 / None / Nas 132785 Dec 12, 2024
@denysbutenko denysbutenko changed the title NAS-132785 / None / Nas 132785 Use cdkDragList for dashboard widgets Dec 12, 2024
@denysbutenko denysbutenko changed the title Use cdkDragList for dashboard widgets NAS-132785 / 25.10 / Use cdkDragList for dashboard widgets Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (db3ec81) to head (fcd88ef).
Report is 50 commits behind head on NAS-132636.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@               Coverage Diff               @@
##           NAS-132636   #11176       +/-   ##
===============================================
- Coverage       82.32%   59.33%   -23.00%     
===============================================
  Files            1652     1646        -6     
  Lines           57923    58304      +381     
  Branches         5957     5988       +31     
===============================================
- Hits            47685    34593    -13092     
- Misses          10238    23711    +13473     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants