Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132906 / 25.04 / Various improvements for containers #11179

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: See ticket for details.

Once Use default network settings is selected, we should not send any NIC devices.

Screenshot 2024-12-13 at 12 38 43

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 13, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 13, 2024 10:40
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team December 13, 2024 10:40
@bugclerk bugclerk changed the title NAS-132906: Various improvements for containers NAS-132906 / 25.04 / Various improvements for containers Dec 13, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (3490c7c) to head (b2c7520).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nents/instance-wizard/instance-wizard.component.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11179   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files        1651     1652    +1     
  Lines       58329    58316   -13     
  Branches     6004     6011    +7     
=======================================
- Hits        48235    48227    -8     
+ Misses      10094    10089    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but let's see some new test cases for changes in functionality.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) December 13, 2024 12:15
@AlexKarpov98 AlexKarpov98 merged commit 19789f4 into master Dec 13, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132906 branch December 13, 2024 12:45
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants