Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Update ethpm docs to reflect v3 changes #620

Closed
wants to merge 3 commits into from

Conversation

njgheorghita
Copy link

@njgheorghita njgheorghita commented Mar 10, 2020

WIP: These are the doc changes to reflect the changes made in upgrading ethpm from v1 -> v3.

trufflesuite/truffle#3247

@OnlyOneJMJQ
Copy link
Contributor

Hi @njgheorghita: I see this is still a draft, but just checking in to let you know I'm aware if it and truffle PR #3247.

@OnlyOneJMJQ OnlyOneJMJQ self-assigned this Aug 14, 2020
@njgheorghita njgheorghita changed the title Update ethpm docs to reflect v2 changes Update ethpm docs to reflect v3 changes Aug 15, 2020
@njgheorghita njgheorghita force-pushed the ethpmv2 branch 3 times, most recently from d6020f8 to e5c5fd1 Compare August 17, 2020 21:44
@njgheorghita njgheorghita marked this pull request as ready for review September 1, 2020 20:32
@OnlyOneJMJQ OnlyOneJMJQ assigned eggplantzzz and gnidan and unassigned OnlyOneJMJQ Oct 2, 2020
@njgheorghita njgheorghita force-pushed the ethpmv2 branch 2 times, most recently from 24db2c1 to b985614 Compare October 27, 2020 16:03

### 1. Set your registry.
By default, your Truffle project will be connected to the default Truffle registry. Some other registries to explore include...
- `libraries.ethpm.eth`: Contains deployments of all [OpenZeppelin](https://github.com/OpenZeppelin/openzeppelin-contracts/) libraries across mainnet and all testnets available to use, so you never have to deploy a library again.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the actual addresses here in parens?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addresses of the deployed libraries on each chain? All of them? Maybe just one for an example? Maybe including etherscan links could be useful? Why do you think it'd be useful to see the addresses here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can they always use the ENS names or do they need to configure it? I was just thinking in case they don't want to deal with ENS. But if it comes with ENS out of the box then I suppose it doesn't matter. Maybe these are documented somewhere and can be linked to?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use ens names - you only need ENS to be enabled in your truffle-config. I've included a line linking to the relevant docs.


The Ethereum Package Registry currently exists on the Ropsten test network. To publish to the registry, we need to set up our own Ropsten configuration because we'll be making transactions that need to be signed.
To publish to any registry, we need to set up our configuration to make signed transactions. If you are publishing to an authorized registry, the signing address must also be authorized to cut a release on the connected registry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does it mean "to be authorized to cut a release on the connected registry"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ethpm registries are permissioned with a general "owner" model (except for the default registry shipping with truffle that is non-permissioned, and therefore not safe to use). Only the "owner" address is allowed to "cut a release" on a registry. Assuming an honest owner, you can trust all of the releases on their registry to be safe to use. This prevents a malicious party from publishing unsafe packages to a registry. It's a somewhat important aspect of ethpm, because it's very unsafe to interact with packages from "untrusted" registries. Lmk if that doesn't really come across in the docs, and I'll expand on it further.

@eggplantzzz
Copy link
Contributor

Integrating this with the blog post work and continuing here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants