Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a mod list from another person's Mint profile export does not maintain order #240

Open
PrincessRTFM opened this issue Aug 25, 2024 · 0 comments

Comments

@PrincessRTFM
Copy link

What it says on the tin. I set up a modpack for playing with some friends and exported my profile, checked that the exported URLs were in the right order, and sent it to them. I expected the import to maintain the order of the URLs, but it didn't, forcing them to arrange the list manually. Ideally, importing multiple URLs should also copy the order of the URLs (placing the whole ordered list at the top of the existing list, if there are any mods already present), but failing that it would be nice to be able to "import" an existing order of mods for those that are installed.

If importing an order of mods for those that are installed, there are three possible cases:

  • Installed mods perfectly match the mods in the imported order (no mods are missing, no extra mods are installed)
    • Nothing special needs to be done.
  • There are additional mods not listed in the imported order (the user has installed mods that weren't in the export)
    • Should they be moved to the top or bottom of the list?
    • Should they be disabled, or left alone?
  • There are missing mods not found in the imported order (the user has not installed all of the mods that were in the export)
    • If the export contains mod.io IDs and the missing mods are on mod.io (instead of being manual file installs), they can be auto-installed
      • But should they be?
      • And what about if the mods aren't on mod.io?
    • Should probably just let the user know they're missing mods
      • If (all? any?) mods can be installed automatically, the popup could also ask the user if they want to download those mods
        • Order assignment would need to happen again after, assuming it was successful, and that could get complicated. Especially with retries.
          • It may be better to not automatically re-apply the order import and instead have the user do it again, or to just not auto-install missing mods in the first place given how many caveats there would be.

There's also the consideration of the export including mod states in the list, and what should be done about mod states on import as well:

  • If mods from the order import are disabled, should they be enabled?
  • If the export includes states, should disabled mods be considered "missing" if not found?
    • Should mods that are enabled on the user's profile but disabled in the import be disabled?

Finally, there's the question of how to handle the export of known mods, particularly if mod states are also exported. However, there's already functionality in place to export the user's mod.io URL list, which is in order. Especially accounting for that, it seems unnecessary to try and implement a whole new order-export system.

Overall, I feel that the first implementation (maintaining order of multiple-URL imports) is probably the simplest and best option, but I wanted to lay out my thoughts on implementing a whole new system as well, in order to make a more complete feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant