Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities List Page: Related documents column #235

Closed
carlosthe19916 opened this issue Nov 12, 2024 · 2 comments · Fixed by #243
Closed

Vulnerabilities List Page: Related documents column #235

carlosthe19916 opened this issue Nov 12, 2024 · 2 comments · Fixed by #243
Assignees

Comments

@carlosthe19916
Copy link
Member

Currently we are rendering an "X" into that column.

We need to render the number of SBOMS affected by the Vulnerability

@kahboom
Copy link
Contributor

kahboom commented Nov 13, 2024

This should be done already through #229 , however, I am not able to get sample data to show a meaningful value in the UI:

Screenshot 2024-11-13 at 11 02 43 AM

Screenshot 2024-11-13 at 11 06 00 AM

And when I try to sort by "Related documents" I'm getting an error in the browser console about the column name being invalid, so I'll have to check that out:

Screenshot 2024-11-13 at 11 08 33 AM

@kahboom kahboom added this to Trustify Nov 13, 2024
@carlosthe19916
Copy link
Member Author

@kahboom I missed #229 sorry.

But:

  • Since in V1 that column is not sortable perhaps we can just remove the sorting feature of that column to avoid issues
  • The "Related Documents" columns is quite ambiguous in V1.
    • Let's ask PM to verify what exactly she expects to see in that column. The current code is rendering the count of CWEs but I am thinking that perhaps it should render the number of SBOMs affected by that Vulnerability and not CWEs. We'll need to confirm it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants