Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sorting options #15

Open
trutzig89182 opened this issue Nov 3, 2022 · 7 comments
Open

Include sorting options #15

trutzig89182 opened this issue Nov 3, 2022 · 7 comments
Labels
feature New feature or request

Comments

@trutzig89182
Copy link
Owner

sort by name or handle. Easiest way would probably be clicking on "account" and "user" in the checkbox section’s heading

@trutzig89182 trutzig89182 added the feature New feature or request label Nov 3, 2022
trutzig89182 added a commit that referenced this issue Nov 4, 2022
@trutzig89182
Copy link
Owner Author

hey, as some people already send me these infomations, we might as well collect them now. (see the commit above). Does the # with _ for space make any sense? and keeping them in one cell? @nathanlesage

@nathanlesage
Copy link
Collaborator

There's a spelling mistake in the profileLink variable in that comit :D

Other than that, you don't have to escape spaces for CSV files, you just need to ensure that you don't use commas in the cells themselves.

@trutzig89182
Copy link
Owner Author

Sorry, this was never meant to be in the comit in main. Was something I have been fooling around with in a branch. And I reverted the comit. So back to normal. :)

@trutzig89182
Copy link
Owner Author

Concerning the _: My though was, that it helps to have them bound together as one Hashtag and then they can escaped when rendering. Otherwise ”#Political Sociology #Family Sociology” would be difficult to be grouped, other than „#Political_Sociology #Family_Sociology”, or am I mistaken?

@nathanlesage
Copy link
Collaborator

Wait, you mean you want to add multiple hashtags per person and you want to disentangle them during display?

In that case, may I suggest another data format such as JSON or YAML? After all, we only need a CSV for people that want to mass-follow other accounts; we do not need a CSV to hold the data. As an upshot, if we store it in JSON format, it'll still be readable for humans but very easy to digest with JavaScript.

trutzig89182 added a commit that referenced this issue Nov 6, 2022
now the list is composed as

- [ ] account (name) Profile(url) – Keywords: kw1, kw2, kw3

refers to #7 #19  #15
trutzig89182 added a commit that referenced this issue Nov 12, 2022
+ Function to select entries with keyword. Save status of selected/non selected keyword in value: true/false.

+function to unselect keywords and show full list

Is more of a concept for now and does not work.

relates to #15
@trutzig89182
Copy link
Owner Author

I think I came up with a possible way to select the shown entries without recreating the list each time (which would probably also pose problem if we want to keep the checkbox status of entries not shown).
I added a "style", "display: normal" tag to the wrapper div for the entry. If a keyword is selected an it’s not in this entry, this will be set to "display: none".

trutzig89182 added a commit that referenced this issue Nov 21, 2022
With the added filtering option the "select all" button could be a bit confusing as it also selects all accouts that are not visible when a specific keyword is active.

This commit changes it, so that only the currently visible accounts are selected, when select all is clicked.

For me this seems more intuitive, but is it?

relates to #15
trutzig89182 added a commit that referenced this issue Nov 21, 2022
relates to #15 #7

Adds languages to webpage and allows to filter list by clicking on them.
However there are still some problems: filtering by keywords and by languages should work in a complementary manner, so that while a language is selected only entries for this language are shown if a keyword is selected in addition. right now, selecting a keyword will just overwrite the selection based on langue.
trutzig89182 added a commit that referenced this issue Nov 22, 2022
* Add handling of empty profile url

If "link" in csv is empty, name will be redered as plain text. An error message is written to the log.

* Update .gitignore

* change selectAll button to select current entries

With the added filtering option the "select all" button could be a bit confusing as it also selects all accouts that are not visible when a specific keyword is active.

This commit changes it, so that only the currently visible accounts are selected, when select all is clicked.

For me this seems more intuitive, but is it?

relates to #15

* avoid build list to break when no "keywords" in CSV file

The building of the list could not be completed without a column "keywords" being in the CSV list. This is fixed here, by not adding keywords when users.keywords is undefined. resolves #64
@trutzig89182
Copy link
Owner Author

Can I reorder the Elements in wrapper without creating a new wrapper?

Perhaps adding a conter to checkbox list entries when creating them (allows to revert to most recent fist later).
And then adding a rank number element to the DOM checkbox list entries based on the alphabetical order of its names.

this would perhaps mean to create a new DOM list from the given DOM list and then substitute the given DOM list with the new one. So that there is no new building of a ordered list from the CSV, but from the given DOM list, thereby maintaining the checked/not checked status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants