Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle, AGP and deps #1156

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Bump Gradle, AGP and deps #1156

merged 2 commits into from
Dec 30, 2023

Conversation

ashutoshgngwr
Copy link
Member

@ashutoshgngwr ashutoshgngwr commented Dec 24, 2023

TODO

  • Bump Firebase BOM
  • Migrate material UI colours to new the system
  • Remove BuildConfig usage

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (262724d) 28.68% compared to head (40589b6) 29.63%.

Files Patch % Lines
...com/github/ashutoshgngwr/noice/NoiceApplication.kt 0.00% 3 Missing ⚠️
...a/com/github/ashutoshgngwr/noice/ext/ContextExt.kt 0.00% 3 Missing ⚠️
...ub/ashutoshgngwr/noice/fragment/LibraryFragment.kt 0.00% 2 Missing ⚠️
...oshgngwr/noice/metrics/GitHubReviewFlowProvider.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1156      +/-   ##
============================================
+ Coverage     28.68%   29.63%   +0.94%     
- Complexity      424      443      +19     
============================================
  Files           167      167              
  Lines          7087     7090       +3     
  Branches        896      893       -3     
============================================
+ Hits           2033     2101      +68     
+ Misses         4731     4657      -74     
- Partials        323      332       +9     
Flag Coverage Δ
api-client 50.24% <ø> (ø)
app 29.01% <60.86%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashutoshgngwr ashutoshgngwr merged commit a972da4 into main Dec 30, 2023
12 checks passed
@ashutoshgngwr ashutoshgngwr deleted the bump-deps branch December 30, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant