-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saga middleware does not work #243
Comments
Is there a reason why you are trying to create saga on the contentScript side? |
How should I trigger content script to query document selector and send result to background, then to popup? I'm looking for a way to do that, was going to use saga on content script @@ |
Content script is what you're going to inject into the website.
In this example case, the content of
In terms of communication between content script and background, as well as popup and background, you can do that using message passing as well as redux. However, your store should be initiated thru background, and you should probably setup |
I need this to work as well, and it seems like it doesn't because it's connected via a subscription to the store instead of as a middleware so actions aren't available to pipe out to the messaging bus. I suspect this can be improved so we are able to pass actions through the bus (and run middlewares out on the proxy store). Am I missing something @tshaddix or does that seem possible to you, too? I need this feature so will give writing it a try and happy to send a PR if others are interested :) |
Yep, alias is great! Doesn’t help for data flow that originates outside the remote ;) |
Could you help me understand in what manner you are trying to use this implementation? I'm running my own middleware in combination with You pointed to this issue, which is related to trying to implementing store creation on the |
Unfortunately Saga created on the contentScript's Store proxy side does not work - it won't receive any actions:
saga:
Example Popup component to test:
and the background reducer:
The text was updated successfully, but these errors were encountered: