Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues(handlers, scan) #169

Open
luckasRanarison opened this issue May 8, 2023 · 0 comments
Open

Minor issues(handlers, scan) #169

luckasRanarison opened this issue May 8, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@luckasRanarison
Copy link

luckasRanarison commented May 8, 2023

Hi there! It's the first time I'm really trying your app and I've encountered some small issues. Unfortunately, I can't work on a fork of your project and make a PR because of my current hardware but I hope this issue helps.

  • The TUI player panics when trying to access empty fields due to the handlers:

image

The Enter events should check if the indexed field is valid

  Key::Enter => {
         if let Some(artist) = app.artist_table.artist.get(app.artist_table.selected_index) {
                app.dispatch(IoEvent::GetArtist(artist.id.clone()));
                app.push_navigation_stack(RouteId::Artist, ActiveBlock::ArtistBlock);
         }
  }

image

  • Deleted songs still appear after re-scaning

image
image

OS: Fedora37
music-player version: v0.2.0-alpha.13

@tsirysndr tsirysndr added the good first issue Good for newcomers label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants