-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add discrepancy function and related things #313
Comments
@hfr1z3 |
|
@petrelharp , I wrote up a discrepancy function with the desired outputs. I did run the following test case: |
Okay, great. Let's see - this is the one on your fork, right? You may as well start a PR with these changes, that'll be easier to keep track of and discuss. |
Hm, let's see. I agree with the check that you have. Here's some other possible checks:
|
We would like to add to
tsdate.evaluation
:match_node_ages
by closest-in-time (and rename tomatch_nodes
, which requires changing the code wherever the function is used)discrepancy
method that returns for the discrepancy betweentsa
andtsb
, the tuple ofa. the total shared span divided by total node span in
tsa
(which we need to compute); so this is proprotion of the span intsa
that is accurately represented intsb
; andb. the root-mean-squared discrepancy in time, with the average weighted by span in
tsa
.The text was updated successfully, but these errors were encountered: