This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Modernize CI #54
Open
Modernize CI #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Reichl <[email protected]>
According to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources, `ubuntu-18.04` is not supported anymore. I would've changed it to `ubuntu-20.04`, but as soon as Canonical releases Ubuntu 24.04, `ubuntu-20.04` will get deprecated again (I guess). So I think `ubuntu-latest` is fine. Signed-off-by: Timo Reichl <[email protected]>
Same reasoning as for `ubuntu-latest`. Signed-off-by: Timo Reichl <[email protected]>
…mann/[email protected] for Windows builds This fixes a lot of issues which point to outdated node12 and outdated/deprecated syntax for build outputs being used. Signed-off-by: Timo Reichl <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically fixes all the CI builds for this project. I tried to explain everything in the commit messages to the best of my ability.