Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snitch purge may fail with empty commit #163

Open
rexim opened this issue Nov 30, 2019 · 0 comments
Open

Snitch purge may fail with empty commit #163

rexim opened this issue Nov 30, 2019 · 0 comments

Comments

@rexim
Copy link
Member

rexim commented Nov 30, 2019

Steps to reproduce

  1. Add the following line to any file in a repo:
// TODO(#<already closed issue id>): some text
  1. Don't commit the change. Leave the tree in the dirty state.
  2. snitch purge
  3. Confirm to delete the recently added TODO

Observed

The snitch removed the TODO but failed to commit the change because there no change. By removing the TODO snitch cleaned up the tree.

Expected

Snitch ignores the empty commit error (maybe issues a warning) and continues deleting the rest of the schedule TODOs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant