Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo _preprocess_df() when sklearn ColumnTransformer has inverse_transform method #16

Open
tsrobinson opened this issue Jun 28, 2022 · 1 comment
Labels
investigating Issue to be investigated new feature New feature or request

Comments

@tsrobinson
Copy link
Owner

sklearn's ColumnTransformer has good functionality for mixed-data pre-processing, and would tidy up some of our code. Currently sklearn lacks inverse transform for this specific Transformer, and although requested here scikit-learn/scikit-learn#11463 and fix proposed here scikit-learn/scikit-learn#11639 does not seem to be implemented yet.

The basic workflow would be to:

  1. Detect datatypes
  2. Build column transformer CT with numeric and categorical encoders
  3. Run SyGNet
  4. Inverse transform generated data using CT.inverse_transform()

Assuming this method is implemented at some point, we should revise our function.

@tsrobinson tsrobinson added new feature New feature or request investigating Issue to be investigated labels Jun 28, 2022
@tsrobinson
Copy link
Owner Author

Still waiting...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating Issue to be investigated new feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant