You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While preparing the Debian package for the new upstream version 0.12.3 I noticed that the test_cmds.sh testcase fails now.
======================================
lnav 0.12.3: test/test-suite.log
======================================
# TOTAL: 39
# PASS: 38
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: test_cmds.sh
==================
[...]
END test_cmds.sh_b6a3bb78e9d60e5e1f5ce5b18e40d2f1662707ab.out
OUT: test: ../src/lnav-test -n -c :switch-to-view help {test_dir}/logfile_access_log.0
--- /home/carnil/lnav/lnav-0.12.3/test/expected/test_cmds.sh_b6a3bb78e9d60e5e1f5ce5b18e40d2f1662707ab.out 2024-1
1-20 05:11:07.000000000 +0000
+++ test_cmds.sh_b6a3bb78e9d60e5e1f5ce5b18e40d2f1662707ab.out 2024-11-24 13:23:55.817819636 +0000
@@ -78,7 +78,7 @@
to write scripts for processing logs with lnav. For example, to get a
list of IP addresses that dhclient has bound to in CSV format:
- ▌#! /usr/bin/lnav -nf
+ ▌#! {prefix}/bin/lnav -nf
▌
▌# Usage: dhcp_ip.lnav /var/log/messages
▌# Only include lines that look like:
FAIL! EXPECTED OUT DIFF
BEGIN test_cmds.sh_b6a3bb78e9d60e5e1f5ce5b18e40d2f1662707ab.err
END test_cmds.sh_b6a3bb78e9d60e5e1f5ce5b18e40d2f1662707ab.err
The problem happens since 697f256 and 7ee9715 adds replacmenet of -e "s;${prefix};{prefix};g" \. so we end in the TESTS_ENVIRONMENT sanitizing/generalizing too much and replacing the /usr in the help text output as well.
The text was updated successfully, but these errors were encountered:
Commit 697f256 ("[tests] sub some more variables in expected
output") introduced new replacements for ${prefix} occurences. In case
where prefix is /usr the TESTS_ENVIRONMENT will additionally replace the
occurence of
#! /usr/bin/lnav -nf
with a
#! {prefix}/bin/lnav -nf
and causing the test_cmds.sh to fail.
Fixes: 697f256 ("[tests] sub some more variables in expected output")
Fixes: tstack#1345
Signed-off-by: Salvatore Bonaccorso <[email protected]>
Hi
While preparing the Debian package for the new upstream version 0.12.3 I noticed that the
test_cmds.sh
testcase fails now.The problem happens since 697f256 and 7ee9715 adds replacmenet of
-e "s;${prefix};{prefix};g" \
. so we end in theTESTS_ENVIRONMENT
sanitizing/generalizing too much and replacing the/usr
in the help text output as well.The text was updated successfully, but these errors were encountered: