[tests] Substitute prefix path to lnav -nf sample in expected help text #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 697f256 ("[tests] sub some more variables in expected output") introduced new replacements for ${prefix} occurences. In case where prefix is /usr the TESTS_ENVIRONMENT will additionally replace the occurence of #! /usr/bin/lnav -nf with a #! {prefix}/bin/lnav -nf and causing the test_cmds.sh to fail. Fixes: 697f256 ("[tests] sub some more variables in expected output") Fixes: tstack#1345 Signed-off-by: Salvatore Bonaccorso <[email protected]>
|
Seems to fail for all checks, but the same pass with the Debian packaging https://salsa.debian.org/carnil/lnav/-/jobs/6643154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 697f256 ("[tests] sub some more variables in expected output") introduced new replacements for ${prefix} occurences. In case where prefix is /usr the TESTS_ENVIRONMENT will additionally replace the occurence of
with a
and causing the test_cmds.sh to fail.
Fixes: 697f256 ("[tests] sub some more variables in expected output")
Fixes: #1345