-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write documentation about multidoc #15
Comments
Pages to be reviewed: Note 1: the second page is only referenced at the end of the first one, but it is not included in any toctree. I think it is fine, because it is simply a template (I am not even sure if it is useful to have it), but I'd be happy to hear your opinion on this page 😃 Note 2: the first page is quite dense of information, let me know if you come up with a smarter way to divide it over multiple pages (in case you think it is needed). Note 3: most of the content of page 1 was taken from this README. I think I will remove most of the README and just leave a link to the online page. Is this okay? |
Tagging - as usual - @DominicDirkx @gaffarelj @geoffreygarrett for review (don't hate me 😆) |
Great job! 🙂 Once again, I made some small edits directly with 0489d3d. It could be good to add, at the beginning of the page, that it is recommended to be familiar with the content of the page about Exposing C++ to Python before trying to dig into exposing docstrings. Indeed, the "how to write docstrings" page is quite dense, but I think that's okay. It should serve as a reference, and not as something that people will read for leasure, so I'm personnaly okay with it staying like this. Nothing to say about the YAML templates. Things are clear and I like that it's going to the point directly. Some small other comments:
I think that this entire paragraph is quite important, but very abstract. Giving a concrete example of a class, and one of its factory function, could help make things more concrete.
This sentence is not very descriptive to me, could you detail it just a tad more (nothing too overkill)? |
Thanks for proofreading and for making the modifications 🙏 I will address your remarks below:
Will do that!
I agree, I also had the same impression. We could also find a way to split it though, let's see what the others say!
Will do this as well 😃
Yes, I will explain it. It simply means the following in the yaml:
Nothing else! |
Changes have been implemented through 934a94b (and published on the website at |
I was already familiar with it, yes. But I think that it would be clear for someone unfamiliar too (though it would require focussing a little bit more I guess).
Great, thanks! Especially, the examples you just added really help for the global clarity imo. |
Great work on this, I only have a few points:
|
Tasks:
The text was updated successfully, but these errors were encountered: